Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STANDARD: Comments Exceptions Upgrade v2.10.0 #505

Open
glhays opened this issue Aug 14, 2023 · 1 comment · May be fixed by #515
Open

STANDARD: Comments Exceptions Upgrade v2.10.0 #505

glhays opened this issue Aug 14, 2023 · 1 comment · May be fixed by #515
Assignees
@glhays
Labels
CODE RUB

Comments

@glhays
Copy link
Collaborator

glhays commented Aug 14, 2023

This issue relates to the Comments ONLY

Upgrade all Comments Exceptions to v2.10.0 of The Standard
See the video explaining the process here

Set all Comments test class method access modifiers to private (Note:) Class file shall remain public

Upgrade appropriate tests to the newer standards where appropriate (see image). Doing this now makes sense as each test is being touched for upgrade.

image

Anyone wanting to take this, please leave a comment letting others know you are working on this.
@glhays glhays self-assigned this Aug 14, 2023
@glhays
Copy link
Collaborator Author

glhays commented Aug 14, 2023

Working on this one.

glhays added a commit that referenced this issue Aug 14, 2023
@glhays
CODE RUB: WIP
5b7283b 
Closes: #505
@glhays glhays linked a pull request Aug 14, 2023 that will close this issue
Open
@glhays glhays changed the title CODE RUB: Comments Exceptions Upgrade v2.10.0 STANDARD: Comments Exceptions Upgrade v2.10.0 Oct 3, 2023
@glhays glhays added STANDARD and removed CODE RUB labels Oct 3, 2023
@glhays glhays added CODE RUB and removed STANDARD labels Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glhays glhays

Labels
CODE RUB
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CODE RUB: Comments Exceptions Upgrade v2.10.0 hassanhabib/Taarafo.Core
1 participant
@glhays