deno lsp support

[DrSensor]

Hi! 👋
Anyone got it works using deno lsp?

In my case, the type checker and autocompletion doesn't works but it still trigger the formatter.
I'm using the master branch via nix build github:helix-editor/helix.

[the-mikedavis]

If you have deno installed, you can configure typescript to use it as the language server with:

# ~/.config/helix/languages.toml
[[language]]
name = "typescript"
language-server = { command = "deno", args = ["lsp"] }

Then you can check that everything is configured correctly with hx --health typescript. If completion is still not working after that, you can consult the log which shows LSP request/response when in verbose mode.

[DrSensor]

Is there a way to set/send initializationOptions?
Based on here and this seems like the client need to send { "enable": true } 🤔

[the-mikedavis]

my highlights.scm is blank in runtime/queries/tsx

Is it actually empty or does it just contain

; inherits: typescript

?

Is there a way to set/send initializationOptions?

IIRC you can use the config key in languages.toml, for example:

helix/languages.toml

Line 130 in c429ed6

config = { "provideFormatter" = true }

[imtheaman]

it's empty doesn't contain anything

[the-mikedavis]

you can copy the queries from runtime/queries/tsx/highlights.scm: https://github.com/helix-editor/helix/blob/master/runtime/queries/tsx/highlights.scm

[imtheaman]

Thanks.💟

[DrSensor]

Alright it works now!

Here is my .config/helix/languages.toml

[[language]]
name = "javascript"
scope = "source.js"
injection-regex = "^(js|javascript)$"
file-types = ["js", "jsx", "mjs"]
shebangs = ["deno", "node"]
roots = ["deno.json", "package.json", "tsconfig.json"]
comment-token = "//"
config = { enable = true, lint = true, unstable = true }
language-server = { command = "deno", args = ["lsp"], language-id = "javascript" }
indent = { tab-width = 2, unit = "  " }

[[language]]
name = "jsx"
scope = "source.jsx"
injection-regex = "jsx"
file-types = ["jsx"]
shebangs = ["deno", "node"]
roots = ["deno.json", "package.json", "tsconfig.json"]
comment-token = "//"
config = { enable = true, lint = true, unstable = true }
language-server = { command = "deno", args = ["lsp"], language-id = "javascriptreact" }
indent = { tab-width = 2, unit = "  " }
grammar = "javascript"

[[language]]
name = "typescript"
scope = "source.ts"
injection-regex = "^(ts|typescript)$"
file-types = ["ts"]
shebangs = ["deno", "node"]
roots = ["deno.json", "package.json", "tsconfig.json"]
config = { enable = true, lint = true, unstable = true }
language-server = { command = "deno", args = ["lsp"], language-id = "typescript" }
indent = { tab-width = 2, unit = "  " }

[[language]]
name = "tsx"
scope = "source.tsx"
injection-regex = "^(tsx)$" # |typescript
file-types = ["tsx"]
shebangs = ["deno", "node"]
roots = ["deno.json", "package.json", "tsconfig.json"]
config = { enable = true, lint = true, unstable = true }
language-server = { command = "deno", args = ["lsp"], language-id = "typescriptreact" }
indent = { tab-width = 2, unit = "  " }

[sigmaSd]

minimal working configuration

[[language]]
name = "typescript"
file-types = ["ts","js"]
language-server = { command = "deno", args = ["lsp"]}
config = { deno = { enable = true, lint = true } }

[David-Else]

Lint is true by default now https://deno.com/blog/v1.22#linting-enabled-by-default-in-the-lsp

[Siilwyn]

Or:

[[language]]
name = "javascript"
language-server = { command = "deno", args = ["lsp"] }
config = { enable = true }

[[language]]
name = "typescript"
language-server = { command = "deno", args = ["lsp"] }
config = { enable = true }

Not sure what benefits the more verbose version in the wiki gives... 🤔

[sigmaSd]

Note that not all deno lsp commands are supported in particular go_to_definition since they require custom deno lsp extensions https://deno.land/manual/language_server/overview

[David-Else]

We need https://github.com/neovim/nvim-lspconfig/blob/master/lua/lspconfig/server_configurations/denols.lua converting for Helix.

[Siilwyn]

Do you by any chance know if this is a decision to not include this in the LSP or could go_to_definition be supported by the LSP in the future?

[David-Else]

I think the Deno crew need to sort this out, they seem to be making their lsp better recently, but it would be best if you go and ask them directly, I don't know what the current status is.

[jakenvac]

Has anyone managed to get import_maps working with Deno and Helix? adding the importMap key in the config doesn't seem to make it work. I've tried relative and absolute paths to it.

EDIT: I'll leave this here as it took me a while to figure out that you need to be in a git repo for the LSP to pick up your import_map. I'm assuming other options to scope the workspace would also work.

[dcompoze]

It seems to work for me - I have the following configuration:

[[language]]
name = "typescript"
shebangs = ["deno", "node"]
roots = ["deno.json", "package.json", "tsconfig.json"]
config = { enable = true, lint = true, unstable = true }
language-server = { command = "deno", args = ["lsp"], language-id = "typescript" }
indent = { tab-width = 2, unit = "  " }

And added the importMap key inside deno.json:

{
    "compilerOptions": {},
    "importMap": "import_map.json"
}

Though when you place the deno.json in a different directory than the import map, the path to the import map needs to be relative from the deno.json file to the import_map.json file.

With a project layout like this:

project
├── deno.json
└── subproject
    ├── import_map.json
    └── src
        └── main.ts

The import map path would be:

"importMap": "subproject/import_map.json"

And if the import_map.json file is at the root (which is normally where it would be):

project
├── deno.json
├── import_map.json
└── src
    └── main.ts

The import map path would be:

"importMap": "import_map.json"

[nathansmith11170]

Sorry to necromance this thread, but it comes up on Google search for deno lsp in Helix and I had issues figuring out the import map.

This is passed to deno lsp in the config, like so:

[[language]]
name = "typescript"
roots = ["deno.json"]
language-server = { command = "deno", args = ["lsp"] }
config = { enable = true, importMap = "deno.json" }

[David-Else]

Would be great to get all info on Deno import map setup in the wiki :)

[AumyF]

I would like Helix to attach typescript-language-server when I editing Node.js projects... How to achieve it? Adding a new language like typescript_deno may help?

Neovim's builtin LSP client has ability to switch the servers according to root_pattern.

[AumyF]

Just for my project configuring using project's .helix/languages/toml solved the problem, but not all Deno projects have a .helix directory.

[jakenvac]

You can always add the .helix directory. That's my preferred way of working on deno with helix.

However, similarly to the link you shared, helix also lets you configure the root for different projects. See here

[jakenvac]

That said, Helix still doesn't support Deno fully. Go to definition doesn't work as the Deno lsp uses a custom url schema for locating the files.

[hemedani]

It's throw error when setup import in deno.json

  "imports": {
    "deps": "../../../libs/bc/dbs/deps.ts",
    "share/": "../../../libs/bc/dbs/",
    "utils/": "../../../libs/bc/utils/",
    "interfaces/": "../../../libs/bc/interfaces/"
  }

relative import path "deps" not prefixed with / or ./ or ../ (import-prefix-missing)

[ar37-rs]

@DrSensor thank you, this is currently languages.toml working fine for me on helix version 23.10:

[[language]]
name = "javascript"
language-id = "javascript"
scope = "source.js"
injection-regex = "^(js|javascript)$"
file-types = ["js", "jsx", "mjs"]
shebangs = ["deno", "node"]
roots = ["deno.json", "package.json", "tsconfig.json"]
comment-token = "//"
indent = { tab-width = 2, unit = "  " }
grammar = "javascript"
language-servers = ["deno-lsp"]

[[language]]
name = "jsx"
language-id = "javascriptreact"
scope = "source.jsx"
injection-regex = "jsx"
file-types = ["jsx"]
shebangs = ["deno", "node"]
roots = ["deno.json", "package.json", "tsconfig.json"]
comment-token = "//"
indent = { tab-width = 2, unit = "  " }
grammar = "javascript"
language-servers = ["deno-lsp"]

[[language]]
name = "typescript"
language-id = "typescript"
scope = "source.ts"
injection-regex = "^(ts|typescript)$"
file-types = ["ts"]
shebangs = ["deno", "node"]
roots = ["deno.json", "package.json", "tsconfig.json"]
comment-token = "//"
indent = { tab-width = 2, unit = "  " }
grammar = "typescript"
language-servers = ["deno-lsp"]

[[language]]
name = "tsx"
language-id = "typescriptreact"
scope = "source.tsx"
injection-regex = "^(tsx)$" # |typescript
file-types = ["tsx"]
shebangs = ["deno", "node"]
roots = ["deno.json", "package.json", "tsconfig.json"]
comment-token = "//"
indent = { tab-width = 2, unit = "  " }
grammar = "typescript"
language-servers = ["deno-lsp"]

[language-server.deno-lsp]
command = "deno"
args = ["lsp", "--unstable"]
config = { enable = true, lint = true, unstable = true }

[jakenvac]

I've not used deno in a while. Does anyone know if goto-definition on external packages works yet?
iirc it's not a failing of helix, but rather deno using extended features of the lsp.

[Cyberphinx]

I've just setup deno-lsp in helix, however, all .tsx file lost all colours:

here is my languages.toml:

[language-server.deno-lsp]
command = "deno"
args = ["lsp", "--unstable"]

[language-server.deno-lsp.config.deno]
enable = true
unstable = true
lint = true
suggest.imports.hosts = { "https://deno.land" = true }
inlayHints.parameterNames.enabled = "all"
inlayHints.parameterTypes.enabled = true
inlayHints.variableTypes.enabled = true
inlayHints.propertyDeclarationTypes.enabled = true
inlayHints.functionLikeReturnTypes.enabled = true
inlayHints.enumMemberValues.enabled = true

[[language]]
name = "javascript"
language-id = "javascript"
scope = "source.js"
injection-regex = "^(js|javascript)$"
file-types = ["js", "jsx", "mjs"]
shebangs = ["deno", "node"]
roots = ["deno.json", "deno.jsonc", "package.json", "tsconfig.json"]
comment-token = "//"
language-servers = ["deno-lsp"]
grammar = "javascript"
indent = { tab-width = 2, unit = "  " }
auto-format = true

[[language]]
name = "jsx"
language-id = "javascriptreact"
scope = "source.jsx"
injection-regex = "jsx"
file-types = ["jsx"]
shebangs = ["deno", "node"]
roots = ["deno.json", "deno.jsonc", "package.json", "tsconfig.json"]
comment-token = "//"
language-servers = ["deno-lsp"]
grammar = "javascript"
indent = { tab-width = 2, unit = "  " }
auto-format = true

[[language]]
name = "typescript"
language-id = "typescript"
scope = "source.ts"
injection-regex = "^(ts|typescript)$"
file-types = ["ts"]
shebangs = ["deno", "node"]
roots = ["deno.json", "deno.jsonc", "package.json", "tsconfig.json"]
comment-token = "//"
language-servers = ["deno-lsp"]
grammar = "typescript"
indent = { tab-width = 2, unit = "  " }
auto-format = true

[[language]]
name = "tsx"
language-id = "typescriptreact"
scope = "source.tsx"
injection-regex = "^(tsx)$"                                          
file-types = ["tsx"]
shebangs = ["deno", "node"]
roots = ["deno.json", "deno.jsonc", "package.json", "tsconfig.json"]
comment-token = "//"
language-servers = ["deno-lsp"]
grammar = "typescript"
indent = { tab-width = 2, unit = "  " }
auto-format = true

[Cyberphinx]

Alright, I fixed it by remove the "grammar" lines

[noahfraiture]

Hello, since deno 2 came out, is there a new way of doing ?

[sigmaSd]

Hi, nope it's still the same (the same as what's in the helix wiki)

[mahmoud-eltahawy]

hello,
in solidjs files. deno lsp assumes it is react and gives me the error

Cannot find name 'React'

[sigmaSd]

Hi, it's probably not related to helix, you should ask on deno discord server

[noahfraiture]

I can't find the information. Do you know how to configure deno lsp to work with svelte files ?

[mahmoud-eltahawy]

currently i quit using deno lsp for tsx files

and i just use compiler errors on the terminal

[aminnairi]

Here is what worked for me as of today

[language-server.deno-language-server]
command = "deno"
args = ["lsp"]
required-root-patterns = ["deno.json", "deno.jsonc"]

[[language]]
name = "typescript"
file-types = ["ts", "tsx"]
language-servers = ["deno-language-server"]

[[language]]
name = "javascript"
file-types = ["js", "jsx"]
language-servers = ["deno-language-server"]

Minimal configuration for making Deno work with JavaScript, JSX, TypeScript, TSX files to add to your ~/.config/helix/languages.toml file.

[timbod7]

This works for me, but only for projects that contain either deno or node typescript. Projects that use both are still problematic. Eg with a directory structure like this:

./deno.json
./packages/foo/package.json
./packages/foo/src/main.ts

when editing packages/foo/scr/main.ts the deno lsp will be used, despite the fact that the there is a package.json file with "closer scope"