Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Borrow "cmdheight=0" feature from neovim #1662

Open
glyh opened this issue Feb 14, 2022 · 5 comments · May be fixed by #12204
Open

Borrow "cmdheight=0" feature from neovim #1662

glyh opened this issue Feb 14, 2022 · 5 comments · May be fixed by #12204
Labels
A-gui Area: Helix gui improvements C-enhancement Category: Improvements

Comments

@glyh
Copy link

glyh commented Feb 14, 2022

Describe your feature request

Here is the PR from neovim's repo.

What this basically does is to hide the command line when it's not used.

Here's an example:

BTW, I actually believe this would be a better default behavior

@glyh glyh added the C-enhancement Category: Improvements label Feb 14, 2022
@EpocSquadron
Copy link
Contributor

Another option to consider that would also address partially #1664 would be to replace the prompt with a picker like ui. There's some repetition of not quite the same code between prompts and pickers, so that might help to simplify code paths as well.

@kirawi kirawi added A-helix-term Area: Helix term improvements A-gui Area: Helix gui improvements and removed A-helix-term Area: Helix term improvements labels Feb 14, 2022
@valpackett
Copy link
Contributor

I really like how Kakoune does it — the cmd prompt is in the status line (all the status stuff is on the right side)

Screen_2022-04-08-22:06:55

@mrdgo
Copy link

mrdgo commented Jul 5, 2024

How is the maintainers opinion on this? What is the status? I mainly use helix in zellij, which also comes with an own bar. That is a line count of three, of which one is not really necessary.

@eliasboegel
Copy link

I very much like this idea. Having an empty line that I rarely look at below the status line permanently is annoying. Having it pop in above the status like when a command is being written seems like a great compromise.

@nik-rev
Copy link
Contributor

nik-rev commented Dec 19, 2024

Just stumbled across this issue. This is similar what #12204 does

@nik-rev nik-rev linked a pull request Dec 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-gui Area: Helix gui improvements C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants