Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork bomb with rust-analyzer clippy #12421

Open
RoloEdits opened this issue Jan 6, 2025 · 8 comments
Open

Fork bomb with rust-analyzer clippy #12421

RoloEdits opened this issue Jan 6, 2025 · 8 comments
Labels
C-bug Category: This is a bug

Comments

@RoloEdits
Copy link
Contributor

RoloEdits commented Jan 6, 2025

Summary

I had noticed this once before but though it was something with my own setup, but saw this reddit post and thought I would make an issue of it, incase its something more.

After opening up the zed repo and trying to check the source code, for example the breadcrumbs.rs, and doing a hover action, it eventually begins to lag as clippy processes are started over and over.

image

Reproduction Steps

helix_fork_bomb

Helix log

https://gist.github.com/RoloEdits/cbabfa4ab230019d8795111c69029063

Platform

Windows

Terminal Emulator

wezterm 20241205-214838-42ecaa64

Installation Method

source

Helix Version

helix 25.1 (2bdb710)

@RoloEdits RoloEdits added the C-bug Category: This is a bug label Jan 6, 2025
@archseer
Copy link
Member

archseer commented Jan 6, 2025

Is this a rust-analyzer issue?

@RoloEdits
Copy link
Contributor Author

RoloEdits commented Jan 6, 2025

I was thinking that as well, but wanted to try to get one place that isnt reddit to discuss, as one person said they were in a vue project and this happened. But seems no one came here to share details in the meantime. I'll open up an issue with RA.

@ngn999
Copy link

ngn999 commented Jan 7, 2025

After open zed master in helix( 25.01 (e698b20)), cpu 100%:
2025-01-07 23 06 25

It looks like another issue.

@RoloEdits
Copy link
Contributor Author

RoloEdits commented Jan 7, 2025

The OP of the reddit post wasnt using rust-analyzer. So it could speak to broader issues.

Did you open up any rust codebase prior to that?
-me

I am a C++ developer :p
- OP

@pascalkuthe
Copy link
Member

Are you using autosave? I would guess it's multiple save requeat running in parallel/not keeping up. In general we dont control when rsut-analayzer runs clippy (it runs on save by default) so I can only imagine us triggering more save notifications

@RoloEdits
Copy link
Contributor Author

Im not explicitly using it in my config. As far as timeouts are concerned I have this.

idle-timeout = 50
completion-timeout = 5

@pascalkuthe
Copy link
Member

We don't use the idle timeout as much anymore but does it also happen without those low timeouts?

@RoloEdits
Copy link
Contributor Author

Commenting it out (so default) it still happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

4 participants