From e92447c105a61fa2b4affee1f7259daa85aced31 Mon Sep 17 00:00:00 2001 From: smx_Moragn <1048492656@qq.com> Date: Wed, 23 Oct 2024 22:38:45 +0800 Subject: [PATCH] fix go lint --- tracing/events.go | 35 ----------------------------------- tracing/options.go | 4 ---- 2 files changed, 39 deletions(-) diff --git a/tracing/events.go b/tracing/events.go index 1684379..7020d86 100644 --- a/tracing/events.go +++ b/tracing/events.go @@ -13,38 +13,3 @@ // limitations under the License. package tracing - -import ( - "github.com/cloudwego/hertz/pkg/common/tracer/stats" - "github.com/cloudwego/hertz/pkg/common/tracer/traceinfo" - "go.opentelemetry.io/otel/attribute" - "go.opentelemetry.io/otel/trace" -) - -var commonEvents = map[string]stats.Event{ - "http_start": stats.HTTPStart, - "http_finish": stats.HTTPFinish, - "server_handle_start": stats.ServerHandleStart, - "server_handle_finish": stats.ServerHandleFinish, - "read_header_start": stats.ReadHeaderStart, - "read_header_finish": stats.ReadHeaderFinish, - "read_body_start": stats.ReadBodyStart, - "read_body_finish": stats.ReadBodyFinish, - "write_start": stats.WriteStart, - "write_finish": stats.WriteFinish, -} - -func injectStatsEventsToSpan(span trace.Span, st traceinfo.HTTPStats) { - for name, event := range commonEvents { - if gotEvent := st.GetEvent(event); gotEvent != nil { - attrs := []attribute.KeyValue{attribute.Int("event.status", int(gotEvent.Status()))} - if gotEvent.Info() != "" { - attrs = append(attrs, attribute.String("event.info", gotEvent.Info())) - } - span.AddEvent(name, - trace.WithTimestamp(gotEvent.Time()), - trace.WithAttributes(attrs...), - ) - } - } -} diff --git a/tracing/options.go b/tracing/options.go index 7b64276..ca41d59 100644 --- a/tracing/options.go +++ b/tracing/options.go @@ -23,10 +23,6 @@ import ( "go.opentelemetry.io/otel/propagation" ) -const ( - instrumentationName = "github.com/hertz-contrib/obs-opentelemetry" -) - // Option opts for opentelemetry tracer provider type Option = otelhertz.Option