Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIP-991 Add max_custom_fees to transactions REST api endpoint #10311

Open
xin-hedera opened this issue Feb 5, 2025 · 0 comments · May be fixed by #10451
Open

HIP-991 Add max_custom_fees to transactions REST api endpoint #10311

xin-hedera opened this issue Feb 5, 2025 · 0 comments · May be fixed by #10451
Labels
enhancement Type: New feature good first issue Good for newcomers rest Area: REST API
Milestone
0.125.0

Comments

@xin-hedera
Copy link
Contributor

xin-hedera commented Feb 5, 2025 •
edited
Loading

Problem

Add max_custom_fees to /api/v1/transactions and /api/v1/transactions/{id} endpoints' response.

Note it's blocked until a new @hashgraph/proto package with 0.59 protobuf changes is published. @hashgraph/proto 2.16.0 is published with 0.59 protobuf changes.

Solution

  • Update the endpoints' response following the design doc

Alternatives

No response
@xin-hedera xin-hedera added enhancement Type: New feature rest Area: REST API labels Feb 5, 2025
@steven-sheehy steven-sheehy added this to the 0.125.0 milestone Feb 17, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Mirror Node Feb 17, 2025
@steven-sheehy steven-sheehy moved this from 📋 Backlog to 🏃‍♀ Sprint backlog in Mirror Node Feb 17, 2025
@steven-sheehy steven-sheehy added the good first issue Good for newcomers label Feb 17, 2025
@SimiHunjan SimiHunjan mentioned this issue Feb 17, 2025
Open
@rbarker-dev rbarker-dev moved this to 🏃‍♀ Sprint backlog in Mirror Node Test - DO NOT USE Feb 20, 2025
@HarshSawarkar HarshSawarkar linked a pull request Feb 21, 2025 that will close this issue
Open
2 tasks
@steven-sheehy steven-sheehy moved this from 🏃‍♀ Sprint backlog to 👀 In review in Mirror Node Feb 21, 2025
@steven-sheehy steven-sheehy moved this from 🏃‍♀ Sprint backlog to 👀 In review in Mirror Node Test - DO NOT USE Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Type: New feature good first issue Good for newcomers rest Area: REST API
Projects
Mirror Node Test - DO NOT USE
Status: 👀 In review
Milestone
0.125.0
Development

Successfully merging a pull request may close this issue.

Added max_custom_fees to transactions REST api endpoint HarshSawarkar/hedera-mirror-node
2 participants
@steven-sheehy @xin-hedera