Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement more useful alerts on chainhook node health #466

Closed
lgalabru opened this issue Dec 22, 2023 · 4 comments
Closed

implement more useful alerts on chainhook node health #466

lgalabru opened this issue Dec 22, 2023 · 4 comments
Assignees
Milestone

Comments

@lgalabru
Copy link
Contributor

Now that the ping endpoint is reporting the bitcoin / stacks block heights, the alarming should be revisited, taking this into account.

@lgalabru
Copy link
Contributor Author

Screenshot 2023-12-22 at 16 44 37

@smcclellan smcclellan moved this from 🆕 New to 📋 Backlog in DevTools Jan 2, 2024
@smcclellan
Copy link
Contributor

@lgalabru to indicate which alarms are needed on this repo.

@MicaiahReid MicaiahReid assigned MicaiahReid and unassigned lgalabru Jan 9, 2024
@MicaiahReid MicaiahReid moved this from 📋 Backlog to 🏗 In Progress in DevTools Jan 9, 2024
@MicaiahReid
Copy link
Contributor

Just adding a quick follow up here - I'm taking on this issue. We'll be adding alerts to Grafana that will notify us if Chainhook block ingestion falls behind block production for either the stacks or bitcoin nodes.

This is requiring us to update Chainhook to emit Prometheus metrics. PR will be incoming soon!

@MicaiahReid MicaiahReid changed the title Revisit alarms implement more useful alerts on chainhook node health Jan 9, 2024
@smcclellan smcclellan added this to the Q1-2024 milestone Jan 19, 2024
@smcclellan smcclellan moved this from 🏗 In Progress to 📋 Backlog in DevTools Jan 25, 2024
MicaiahReid added a commit that referenced this issue Feb 8, 2024
### Description

To enable improved alerts on downtime for Hiro's hosted Chainhook
service, we need Chainhook to provide metrics that can be ingested by
Prometheus. This PR changes some how we track our metrics (that are
served over the `/ping` endpoint of the observer) to enable Prometheus
compatibility, and adds a flag to optionally start a server to supply
metrics to a Prometheus client.


### Example

Starting chainhook with the `--prometheus-port XXXX` flag now enables a
service that can supply Prometheus metrics at `localhost:XXXX/metrics`.

If using a config file, this option can be specified via:
```yaml
[monitoring]
prometheus_monitoring_port = XXXX
```

Chainhook will behave as usual with this flag ommitted - metrics can
still be retrieved via the observer's `/ping` endpoint, but they will
not be formatted for ingestion by a Prometheus client.

---

### Checklist

- [X] All tests pass
- [X] Tests added in this PR (if applicable)

Fixes #474, addresses #466
MicaiahReid added a commit that referenced this issue Feb 8, 2024
### Description

To enable improved alerts on downtime for Hiro's hosted Chainhook
service, we need Chainhook to provide metrics that can be ingested by
Prometheus. This PR changes some how we track our metrics (that are
served over the `/ping` endpoint of the observer) to enable Prometheus
compatibility, and adds a flag to optionally start a server to supply
metrics to a Prometheus client.


### Example

Starting chainhook with the `--prometheus-port XXXX` flag now enables a
service that can supply Prometheus metrics at `localhost:XXXX/metrics`.

If using a config file, this option can be specified via:
```yaml
[monitoring]
prometheus_monitoring_port = XXXX
```

Chainhook will behave as usual with this flag ommitted - metrics can
still be retrieved via the observer's `/ping` endpoint, but they will
not be formatted for ingestion by a Prometheus client.

---

### Checklist

- [X] All tests pass
- [X] Tests added in this PR (if applicable)

Fixes #474, addresses #466
@MicaiahReid MicaiahReid moved this from 📋 Backlog to 🚢 Ready to Release in DevTools Feb 12, 2024
@MicaiahReid MicaiahReid moved this from 🚢 Ready to Release to ✅ Done in DevTools Feb 12, 2024
@MicaiahReid
Copy link
Contributor

Closing, because everything is complete on the chainhook side with PR #473. The devops side is being tracked by https://github.com/hirosystems/devops/issues/1543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants