Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to delete an email/subscriber from the list times out #684

Open
Znuff opened this issue Sep 2, 2023 · 6 comments
Open

Attempting to delete an email/subscriber from the list times out #684

Znuff opened this issue Sep 2, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@Znuff
Copy link

Znuff commented Sep 2, 2023

Description

When attempting to delete a subscriber from the list, the request hangs indefinitely.

The HTTP request seems to trigger, but never completes.

There are no error messages in the server log. This request doesn't even trigger a slow log from PHP's side.

The modal will wait forever, because on the browser side the request will never finish.

Screenshots

image

Additional information

No response

@Znuff Znuff added the bug Something isn't working label Sep 2, 2023
@picocodes
Copy link
Collaborator

picocodes commented Sep 5, 2023

Hi @Znuff,

  • Open your browser's console when deleting and check if any error shows up.
  • Also click on the network tab and check the response returned from the server.

@Znuff
Copy link
Author

Znuff commented Sep 5, 2023

There is no error in the console.

The request never finishes in the browser, even after 10+ minutes.

If you examine the access log on the server side, the server does decide to give up (with a 408 in the case of our nginx).

chrome_2023-09-05_07-05-19

It's good to note that if you actually execute the Request via cURL (Right Click > Copy as cURL), the email address is deleted as expected.

@picocodes
Copy link
Collaborator

That's strange. Does this happen when you try a different browser? Also, does it only happen when deleting subscribers or is it also the case when editing subscribers?

@Znuff
Copy link
Author

Znuff commented Sep 5, 2023

Happens in Firefox and Chrome.

Only when deleting. Modifying works fine.

Seems I have it pinned down to HTTP/3 being enabled. Disabling HTTP/3 server-side seems to make it work.

Explains why running it via curl works (as my curl binary doesn't have support for it).

@picocodes
Copy link
Collaborator

Thanks. I think we can fix it with this:- https://developer.wordpress.org/rest-api/using-the-rest-api/global-parameters/#_method-or-x-http-method-override-header

I'll make the necessary changes then let you know later today.

@picocodes
Copy link
Collaborator

Upon further inspection it seems this is already implemented in core. I'll look more into why HTTP/3 fails then get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants