From 6544d78438439d3d4adf55af4281623fb62e0692 Mon Sep 17 00:00:00 2001
From: jonatantreijs <62055117+jonatantreijs@users.noreply.github.com>
Date: Fri, 10 Jan 2025 13:02:48 +0100
Subject: [PATCH] Add callback for onChangeText to jsoneditor.ts (#7610)

* Add callback for jsoneditor.onChangeText

* Test jsoneditor editing while in text mode

* Fix lint issue
---
 panel/models/jsoneditor.ts                |  7 +++++++
 panel/tests/ui/widgets/test_jsoneditor.py | 16 ++++++++++++++++
 2 files changed, 23 insertions(+)

diff --git a/panel/models/jsoneditor.ts b/panel/models/jsoneditor.ts
index eafc454353..9cfa287b17 100644
--- a/panel/models/jsoneditor.ts
+++ b/panel/models/jsoneditor.ts
@@ -69,6 +69,13 @@ export class JSONEditorView extends HTMLBoxView {
       onChangeJSON: (json: any) => {
         this.model.data = json
       },
+      onChangeText: (text: any) => {
+        try {
+          this.model.data = JSON.parse(text)
+        } catch (e) {
+          console.warn(e)
+        }
+      },
       onSelectionChange: (start: any, end: any) => {
         this.model.selection = [start, end]
       },
diff --git a/panel/tests/ui/widgets/test_jsoneditor.py b/panel/tests/ui/widgets/test_jsoneditor.py
index cea0fe2eb5..c96779b67b 100644
--- a/panel/tests/ui/widgets/test_jsoneditor.py
+++ b/panel/tests/ui/widgets/test_jsoneditor.py
@@ -35,3 +35,19 @@ def test_json_editor_edit(page):
     page.locator('.jsoneditor').click()
 
     wait_until(lambda: editor.value['str'] == 'new', page)
+
+def test_json_editor_edit_in_text_mode(page):
+    editor = JSONEditor(value={'str': 'string', 'int': 1}, mode='text')
+
+    msgs, _ = serve_component(page, editor)
+
+    expect(page.locator('.jsoneditor')).to_have_count(1)
+
+    page.locator('.jsoneditor-text').click()
+    ctrl_key = 'Meta' if sys.platform == 'darwin' else 'Control'
+    page.keyboard.press(f'{ctrl_key}+A')
+    page.keyboard.press('Backspace')
+    page.keyboard.type('{"str": "new"}')
+    page.locator('.jsoneditor').click()
+
+    wait_until(lambda: editor.value['str'] == 'new', page)