Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order of arguments #6

Open
gr2m opened this issue Dec 20, 2015 · 2 comments · May be fixed by #8
Open

Change order of arguments #6

gr2m opened this issue Dec 20, 2015 · 2 comments · May be fixed by #8

Comments

@gr2m
Copy link
Member

gr2m commented Dec 20, 2015

I’d like to put secret first, that we can easily expose a calculateSessionId(username, salt, timestamp) method with

calculateSessionId = require('couchdb-calculate-session-id').bind(null, 'secret')

I think that order makes also more sense in terms of grade of security

@marten-de-vries
Copy link
Collaborator

The order doesn't matter for pouchdb-auth, it's something I would need to look up in the docs every time anyway. So feel free to use whatever order makes the most sense to you. :)

@gr2m gr2m linked a pull request Dec 25, 2015 that will close this issue
@gr2m
Copy link
Member Author

gr2m commented Dec 25, 2015

Started a PR here: #8

@janl @boennemann @christophwitzko any reason against putting secret first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants