Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hoodie.reset: clean up code and add proper tests and documentation #108

Closed
gr2m opened this issue Jul 9, 2016 · 1 comment
Closed

hoodie.reset: clean up code and add proper tests and documentation #108

gr2m opened this issue Jul 9, 2016 · 1 comment
Assignees

Comments

@gr2m
Copy link
Member

gr2m commented Jul 9, 2016

the definition of the reset method currently looks like this:

function reset (dbName, CustomPouchDB, state, api, clear, emitter, remoteBaseUrl, remote, ajaxOptions, PouchDB, options) {
// ...
}

it should look more like this

reset (state, options) {
// ...
}

Where state is different from the internal state of the store instance, but having to bind 10 arguments in the right order is not very good to understand / manage.

Maybe there even is a more elegant way to implement the reset in the first place?

Update

also add documentation to README.md

@gr2m gr2m self-assigned this Nov 16, 2016
@LowProfileDog LowProfileDog changed the title hoodie.reset: clean up code and add proper tests hoodie.reset: clean up code and add proper tests and documentation May 9, 2017
@gr2m
Copy link
Member Author

gr2m commented Jun 20, 2017

code gets cleaned up via #153

@gr2m gr2m closed this as completed Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant