Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loader not dismissing in case of login failure #259

Closed
2 tasks
amansinghbais opened this issue Feb 8, 2024 · 2 comments · May be fixed by #260
Closed
2 tasks

Fix loader not dismissing in case of login failure #259

amansinghbais opened this issue Feb 8, 2024 · 2 comments · May be fixed by #260
Assignees
@Adameddy26
Labels
bug Something isn't working

Comments

@amansinghbais
Copy link
Contributor

Current behavior

Loader not getting dismissed in case of login failure when any api throws an error.

Expected behavior

Loader should be dismissed after the execution of api whether it fails or success.

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

  • YES
  • NO

Environment details

  • Browser:
  • OS:
  • Code Version:

Additional information
@amansinghbais amansinghbais self-assigned this Feb 8, 2024
@Ritika-Patel08 Ritika-Patel08 mentioned this issue Feb 8, 2024
Open
1 task
@Ritika-Patel08 Ritika-Patel08 moved this to 👀 In review in Digital Experience Platform Feb 21, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Digital Experience Platform Jul 15, 2024
@dt2patel dt2patel reopened this Jul 15, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 📅 Planned in Digital Experience Platform Jul 15, 2024
@dt2patel dt2patel assigned ravilodhi and unassigned Ritika-Patel08 Jul 15, 2024
@ravilodhi ravilodhi moved this from 📅 Planned to 📋 Backlog in Digital Experience Platform Jul 15, 2024
@ravilodhi ravilodhi removed their assignment Jul 15, 2024
@Dhiraj1405 Dhiraj1405 moved this from 📋 Backlog to 👀 In review in Digital Experience Platform Jul 26, 2024
@ravilodhi
Copy link
Contributor

@Adameddy26 Please check whether this issue still persists.

@Adameddy26 Adameddy26 moved this from 👀 In review to 🛠 In QA in Digital Experience Platform Nov 8, 2024
@Adameddy26 Adameddy26 self-assigned this Nov 8, 2024
@Adameddy26 Adameddy26 added the bug Something isn't working label Nov 8, 2024
@Adameddy26
Copy link

Verified and working fine. Hence, closing this ticket.

@github-project-automation github-project-automation bot moved this from 🛠 In QA to ✅ Done in Digital Experience Platform Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
bug Something isn't working
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed: loader which was not getting dismissed when API failed Ritika-Patel08/dxp-components
5 participants
@ravilodhi @dt2patel @amansinghbais @Ritika-Patel08 @Adameddy26