Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to use the bulk facility group addition and updation api #319

Open
1 of 3 tasks
ymaheshwari1 opened this issue Sep 27, 2024 · 0 comments
Open
1 of 3 tasks
Labels
enhancement New feature or request hacktoberfest Good issue for Hacktoberfest event

Comments

@ymaheshwari1
Copy link
Contributor

What is the motivation for adding/enhancing this feature?

Currently we call the api multiple times in a loop for addition or updation of facility groups, instead we need to use bulkAddFacilityToGroup and bulkUpdateFacilityToGroup for addition/updation of multiple facility groups at once.

What are the acceptance criteria?

  • Remove the apis updateFacilityToGroup and addFacilityToGroup and instead use the newly added apis bulkUpdateFacilityToGroup and bulkAddFacilityToGroup

Can you complete this feature request by yourself?

  • YES
  • NO

Additional information

Request Payload for bulkAddFacilityToGroup:

{
        "facilityList" : [
            {
                "facilityGroupId" : "PICKUP",
                "facilityId" : "GENERAL_OPS_PARKING",
                "sequenceNum" : "1"
            },
            {
                "facilityGroupId" : "PICKUP",
                "facilityId" : "REJECTED_ITM_PARKING",
                "sequenceNum" : "2"
            }
        ]
    }

Request payload for bulkUpdateFacilityToGroup:

{
        "facilityList" : [
            {
                "facilityGroupId" : "PICKUP",
                "facilityId" : "CONFIGURATION",
                "fromDate" : "",
                "thruDate" : ""
            },
            {
                "facilityGroupId" : "PICKUP",
                "facilityId" : "REJECTED_ITM_PARKING",
                "fromDate" : "",
                "thruDate" : ""
            }
        ]
    }

The data passed in the above payloads will be same as how its currently passed.

@ymaheshwari1 ymaheshwari1 added enhancement New feature or request hacktoberfest Good issue for Hacktoberfest event labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest Good issue for Hacktoberfest event
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant