Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login buttons are constant regardless of available login types #834

Open
agc93 opened this issue Oct 19, 2023 · 1 comment
Open

Login buttons are constant regardless of available login types #834

agc93 opened this issue Oct 19, 2023 · 1 comment

Comments

@agc93
Copy link

agc93 commented Oct 19, 2023

When self-hosting Watchparty, the top bar will still always show Email, Facebook and Google sign-in methods, regardless of what providers are actually available on the Firebase end.

For example, in my deployment, I have disabled Facebook and Email, but enabled OIDC to connect with an SSO provider. However, there is no way for a user to actually log in with OIDC, and a non-functional Facebook login is still offered in the UI since TopBar.tsx has the three login methods hard-coded in.

Would it be possible to:

  • Have a configuration option (something like REACT_APP_ENABLE_*, or REACT_APP_LOGIN_PROVIDERS) to enable/disable specific login providers
  • Add/allow logging in by OIDC, or any of the other Firebase-supported login providers (i.e. GitHub, Microsoft etc)
@howardchung
Copy link
Owner

This is a good idea--I like the idea of having a client side variable to configure it. We do need to add a UI implementation for each supported option though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants