Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php artisan translation:fetch failing on Windows #17

Open
mst101 opened this issue Nov 29, 2016 · 0 comments
Open

php artisan translation:fetch failing on Windows #17

mst101 opened this issue Nov 29, 2016 · 0 comments

Comments

@mst101
Copy link

mst101 commented Nov 29, 2016

The above artisan command is failing on Windows because the cleanLocaleDir function in /src/Console/Commands/FetchCommand.php is looking for a forward slash, as opposed to a backslash.

To get my local copy to work, I changed:

protected function cleanLocaleDir($item) {
        return str_replace($this->lang_path.'/', '', $item);
}

to

protected function cleanLocaleDir($item) {
        return str_replace($this->lang_path.'\\', '', $item);
}

...but you may want to create a more robust solution?

Thanks for the handy tool though. Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant