Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAP matching rules do not work when space separated (comma separated works) #64

Open
cloudshiftchris opened this issue Sep 10, 2023 · 2 comments

Comments

@cloudshiftchris
Copy link

Using EAP version of plugin w/ IntelliJ

IntelliJ IDEA 2023.2.1 (Ultimate Edition)
Build #IU-232.9559.62, built on August 22, 2023
Licensed to ****
Subscription is active until July 6, 2024.
Runtime version: 17.0.8+7-b1000.8 aarch64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 13.5.2
GC: G1 Young Generation, G1 Old Generation
Memory: 6144M
Cores: 10
Metal Rendering is ON
Registry:
    debugger.new.tool.window.layout=true
    ide.experimental.ui=true
    kotlin.scripting.index.dependencies.sources=true

Non-Bundled Plugins:
    ski.chrzanow.foldableprojectview (2.0.0-EAP.1)
    AWSCloudFormation (232.8660.88)
    org.rust.lang (0.4.200.5421-232)
    com.github.b3er.idea.plugins.arc.browser (0.32)
    String Manipulation (9.11.3)
    de.achimonline.github_markdown_emojis (1.3.2)
    com.jetbrains.php (232.9559.64)
    mobi.hsz.idea.gitignore (4.5.1)
    org.jetbrains.plugins.go (232.9559.65)
    kotest-plugin-intellij (1.3.69-IC-232-EAP-SNAPSHOT)
    izhangzhihao.rainbow.brackets (2023.3.4)

Kotlin: 232-1.9.0-IJ9559.62

In addition to #62 where files are not hidden in the Project view there is an issue when specifying multiple glob patterns.

Specifying them space-separated does not work; it results in the named group being empty (matching nothing). Specifying them comma-separated works (the group now contains all the matched files, though they are not hidden from the main Project view).

Does not work: gradle* .* *.gradle.kts
Works: gradle*,.*,*.gradle.kts

The UI indicates that spaces should be used: Glob-like space-separated folding rules, like: README.md *.yml gradle*

@cloudshiftchris
Copy link
Author

Looks to be this code in ski.chrzanow.foldableprojectview.psi.search.FoldableProjectSearchScope:

    private val patterns = pattern
        .applySettings()
        .split(',')
        .filter(String::isNotBlank)
        .mapNotNull {
            patternCache.createPattern(it, Syntax.GLOB)

@shuohao
Copy link

shuohao commented Dec 20, 2023

Using EAP version of plugin w/ IntelliJ

IntelliJ IDEA 2023.2.1 (Ultimate Edition)
Build #IU-232.9559.62, built on August 22, 2023
Licensed to ****
Subscription is active until July 6, 2024.
Runtime version: 17.0.8+7-b1000.8 aarch64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 13.5.2
GC: G1 Young Generation, G1 Old Generation
Memory: 6144M
Cores: 10
Metal Rendering is ON
Registry:
    debugger.new.tool.window.layout=true
    ide.experimental.ui=true
    kotlin.scripting.index.dependencies.sources=true

Non-Bundled Plugins:
    ski.chrzanow.foldableprojectview (2.0.0-EAP.1)
    AWSCloudFormation (232.8660.88)
    org.rust.lang (0.4.200.5421-232)
    com.github.b3er.idea.plugins.arc.browser (0.32)
    String Manipulation (9.11.3)
    de.achimonline.github_markdown_emojis (1.3.2)
    com.jetbrains.php (232.9559.64)
    mobi.hsz.idea.gitignore (4.5.1)
    org.jetbrains.plugins.go (232.9559.65)
    kotest-plugin-intellij (1.3.69-IC-232-EAP-SNAPSHOT)
    izhangzhihao.rainbow.brackets (2023.3.4)

Kotlin: 232-1.9.0-IJ9559.62

In addition to #62 where files are not hidden in the Project view there is an issue when specifying multiple glob patterns.

Specifying them space-separated does not work; it results in the named group being empty (matching nothing). Specifying them comma-separated works (the group now contains all the matched files, though they are not hidden from the main Project view).

Does not work: gradle* .* *.gradle.kts Works: gradle*,.*,*.gradle.kts

The UI indicates that spaces should be used: Glob-like space-separated folding rules, like: README.md *.yml gradle*

try this
https://github.com/shuohao/intellij-foldable-project-view/releases/tag/2.0.0-EAP-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants