Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add D-FINE #35283

Open
2 tasks done
brockt96 opened this issue Dec 15, 2024 · 16 comments
Open
2 tasks done

Request to add D-FINE #35283

brockt96 opened this issue Dec 15, 2024 · 16 comments
Labels
contributions-welcome Good Second Issue Issues that are more difficult to do than "Good First" issues - give it a try if you want! New model Vision

Comments

@brockt96
Copy link

brockt96 commented Dec 15, 2024

Model description

D-FINE is a RT-DETR based model that uses probability distributions as an intermediate representation from which bounding boxes are predicted. This model has achieved SOTA results in real-time object detection with additional training data. https://paperswithcode.com/sota/real-time-object-detection-on-coco?p=d-fine-redefine-regression-task-in-detrs-as

Open source status

  • The model implementation is available
  • The model weights are available

Provide useful links for the implementation

Here is the link to the repository: https://github.com/Peterande/D-FINE. The weights are present on Huggingface Hub. The only github username I know of is @Peterande.

@qubvel qubvel added Good Second Issue Issues that are more difficult to do than "Good First" issues - give it a try if you want! Vision contributions-welcome labels Dec 16, 2024
@qubvel
Copy link
Member

qubvel commented Dec 16, 2024

Hi @brockt96! Thanks for opening this issue 🙌. D-FINE would be an amazing addition to Transformers! If you're interested in working on it, we'd be excited to support you. Otherwise, let's see if anyone in the community is eager to contribute to integrating this model. Let me know what you think! 🤗

@VladOS95-cyber
Copy link
Contributor

Hi @qubvel @brockt96! I could contribute into this model if for some reasons nobody is going to work on this.

@NielsRogge
Copy link
Contributor

Hi @VladOS95-cyber that would be super cool! Feel free to open a PR. Cc'ing also @SangbumChoi who contributed RT-DETR

@SangbumChoi
Copy link
Contributor

#34773
#33244
If you see these PR then it will be much more easier to do D-FINE as modular.

@qubvel
Copy link
Member

qubvel commented Dec 16, 2024

Hi @VladOS95-cyber, that's super cool! feel free to ping me when PR is open!

Since the model is based on RT-DETR, please, use modular for the model addition. And in addition to the above PRs, mentioned by @SangbumChoi it's worth looking at:

@brockt96
Copy link
Author

Hi @brockt96! Thanks for opening this issue 🙌. D-FINE would be an amazing addition to Transformers! If you're interested in working on it, we'd be excited to support you. Otherwise, let's see if anyone in the community is eager to contribute to integrating this model. Let me know what you think! 🤗

I'd love to work it! Though I hasten to add that I have no freaking clue what I'm doing.😅 But, that's part of the reason why I want to do this. I want to learn. And I want to be able to tame these "researchy" models, as y'all call them. I think this will be a good experience all things considered.

@VladOS95-cyber
Copy link
Contributor

Hi @brockt96! Thanks for opening this issue 🙌. D-FINE would be an amazing addition to Transformers! If you're interested in working on it, we'd be excited to support you. Otherwise, let's see if anyone in the community is eager to contribute to integrating this model. Let me know what you think! 🤗

I'd love to work it! Though I hasten to add that I have no freaking clue what I'm doing.😅 But, that's part of the reason why I want to do this. I want to learn. And I want to be able to tame these "researchy" models, as y'all call them. I think this will be a good experience all things considered.

Hi @brockt96! Are you going to work on it then?

@brockt96
Copy link
Author

Hi @brockt96! Thanks for opening this issue 🙌. D-FINE would be an amazing addition to Transformers! If you're interested in working on it, we'd be excited to support you. Otherwise, let's see if anyone in the community is eager to contribute to integrating this model. Let me know what you think! 🤗

I'd love to work it! Though I hasten to add that I have no freaking clue what I'm doing.😅 But, that's part of the reason why I want to do this. I want to learn. And I want to be able to tame these "researchy" models, as y'all call them. I think this will be a good experience all things considered.

Hi @brockt96! Are you going to work on it then?

Yes. Although I won't be able to do so full-time.

@bhuvanmdev
Copy link
Contributor

Hi @brockt96! Thanks for opening this issue 🙌. D-FINE would be an amazing addition to Transformers! If you're interested in working on it, we'd be excited to support you. Otherwise, let's see if anyone in the community is eager to contribute to integrating this model. Let me know what you think! 🤗

I'd love to work it! Though I hasten to add that I have no freaking clue what I'm doing.😅 But, that's part of the reason why I want to do this. I want to learn. And I want to be able to tame these "researchy" models, as y'all call them. I think this will be a good experience all things considered.

Hi @brockt96! Are you going to work on it then?

Yes. Although I won't be able to do so full-time.

If you're not available to do this, do let me know. I can take it up. :)

@brockt96
Copy link
Author

Hi @brockt96! Thanks for opening this issue 🙌. D-FINE would be an amazing addition to Transformers! If you're interested in working on it, we'd be excited to support you. Otherwise, let's see if anyone in the community is eager to contribute to integrating this model. Let me know what you think! 🤗

I'd love to work it! Though I hasten to add that I have no freaking clue what I'm doing.😅 But, that's part of the reason why I want to do this. I want to learn. And I want to be able to tame these "researchy" models, as y'all call them. I think this will be a good experience all things considered.

Hi @brockt96! Are you going to work on it then?

Yes. Although I won't be able to do so full-time.

If you're not available to do this, do let me know. I can take it up. :)

After thinking about it, truthfully, it'll probably be better if you take it up. But, I do still want to contribute. So let me know what I can do to support.

@VladOS95-cyber
Copy link
Contributor

Hey @brockt96, ok, I'll take care of it

@qubvel
Copy link
Member

qubvel commented Dec 19, 2024

@VladOS95-cyber super cool 👍 feel free to ping me for any questions

@VladOS95-cyber
Copy link
Contributor

@VladOS95-cyber super cool 👍 feel free to ping me for any questions

@qubvel, sure, thank you!

@Realmbird
Copy link

@VladOS95-cyber could I try contribute if you didn't finish since there are not many first issues

@Realmbird
Copy link

@qubvel

@VladOS95-cyber
Copy link
Contributor

@VladOS95-cyber could I try contribute if you didn't finish since there are not many first issues

hey, i'am currently working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions-welcome Good Second Issue Issues that are more difficult to do than "Good First" issues - give it a try if you want! New model Vision
Projects
None yet
Development

No branches or pull requests

7 participants