Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for reverted transaction that should succeed on EVM 2024-12 #1402

Open
dmitrylavrenov opened this issue Jan 16, 2025 · 5 comments
Open

Tracking issue for reverted transaction that should succeed on EVM 2024-12 #1402

dmitrylavrenov opened this issue Jan 16, 2025 · 5 comments
Labels
tracking A tracking issue for a big multi-PR initiative

Comments

@dmitrylavrenov
Copy link
Contributor

dmitrylavrenov commented Jan 16, 2025 •
edited by MOZGIII
Loading

This is a tracking issue for investigating the reason of reverted transaction that should succeed on EVM, getting root cause, reproducing the issue, implementing a proper fix.

Bugfix PRs:

Internal playground utils:
@dmitrylavrenov
Copy link
Contributor Author

succeded transaction:

failed transaction:

@dmitrylavrenov
Copy link
Contributor Author

  • prepared the humanode-peer version with enabled debug of evm opcodes operation taking into account the value of left gas
  • rerun the same process as above for succeeded (block number 7927643) and failed (block number 10507907) transactions

logs-7927643.txt
logs-10507907.txt

@dmitrylavrenov
Copy link
Contributor Author

  • added more debug logs
  • discovered the root cause why is the failed transaction reverted

There is a broken nonce in our state for 0xf803e8ca755ae4770b5e6072a1e3cb97631d76ee contract address

@dmitrylavrenov
Copy link
Contributor Author

dmitrylavrenov commented Jan 16, 2025 •
edited
Loading

The block containing transactions that resulted into 0xf803e8ca755ae4770b5e6072a1e3cb97631d76ee contract account killing - https://humanode.subscan.io/extrinsic/7969497-1

Note: all contract tokens have been withdrawn

@dmitrylavrenov dmitrylavrenov added the tracking A tracking issue for a big multi-PR initiative label Jan 16, 2025
quasiyoke added a commit that referenced this issue Jan 16, 2025
@quasiyoke
E2E-test: withdrawAll from the contracts' factory between two CREATEs
01b8336 
(#1402)
quasiyoke added a commit that referenced this issue Jan 16, 2025
@quasiyoke
Use payable constructor instead of deposit (#1402)
f263e1e
quasiyoke added a commit that referenced this issue Jan 16, 2025
@quasiyoke
Simplify test contract Deposit ← ContractsFactory (#1402)
abc957b
quasiyoke added a commit that referenced this issue Jan 16, 2025
@quasiyoke
Hardcode gas values, remove excess calls (#1402)
60536be
quasiyoke added a commit that referenced this issue Jan 16, 2025
@quasiyoke
Check contract account's nonce directly (#1402)
05d27ee
@quasiyoke quasiyoke mentioned this issue Jan 16, 2025
Merged
@dmitrylavrenov
Copy link
Contributor Author

Implemented E2E test that reproduces the issue - #1398

@dmitrylavrenov dmitrylavrenov mentioned this issue Jan 16, 2025
Merged
quasiyoke added a commit that referenced this issue Jan 16, 2025
@quasiyoke
Simplify test contract Deposit ← ContractsFactory (#1402)
aef831d
quasiyoke added a commit that referenced this issue Jan 16, 2025
@quasiyoke
Hardcode gas values, remove excess calls (#1402)
1a4163d
quasiyoke added a commit that referenced this issue Jan 16, 2025
@quasiyoke
Check contract account's nonce directly (#1402)
d7645ca
quasiyoke added a commit that referenced this issue Jan 17, 2025
@quasiyoke
Simplify test contract Deposit ← ContractsFactory (#1402)
bec43c9
quasiyoke added a commit that referenced this issue Jan 17, 2025
@quasiyoke
Hardcode gas values, remove excess calls (#1402)
b389334
quasiyoke added a commit that referenced this issue Jan 17, 2025
@quasiyoke
Check contract account's nonce directly (#1402)
bed6532
This was referenced Feb 7, 2025
Closed
Merged
quasiyoke added a commit that referenced this issue Feb 10, 2025
@quasiyoke
E2E-test: withdrawAll from the contracts' factory between two CREATEs
d4ac9bc 
(#1402)
quasiyoke added a commit that referenced this issue Feb 10, 2025
@quasiyoke
Use payable constructor instead of deposit (#1402)
74add8d
quasiyoke added a commit that referenced this issue Feb 10, 2025
@quasiyoke
Simplify test contract Deposit ← ContractsFactory (#1402)
eef4ef8
quasiyoke added a commit that referenced this issue Feb 10, 2025
@quasiyoke
Hardcode gas values, remove excess calls (#1402)
7f089e6
quasiyoke added a commit that referenced this issue Feb 10, 2025
@quasiyoke
Check contract account's nonce directly (#1402)
069513c
github-merge-queue bot pushed a commit that referenced this issue Feb 10, 2025
@quasiyoke
E2E: make sure that contract account's state doesn't vanish after emp…
213e899 
…tying its wallet (#1398)

* E2E-test: `withdrawAll` from the contracts' factory between two CREATEs
(#1402)

* Use payable constructor instead of `deposit` (#1402)

* Simplify test contract Deposit ← ContractsFactory (#1402)

* Hardcode gas values, remove excess calls (#1402)

* Check contract account's nonce directly (#1402)
quasiyoke added a commit that referenced this issue Feb 10, 2025
@quasiyoke
Migrate EVM-managed accounts' state with broken nonce;
b8f8edc 
compute min unused nonce (#1402)
quasiyoke added a commit that referenced this issue Feb 10, 2025
@quasiyoke
Migrate EVM-managed accounts' state with broken nonce;
c19a69b 
compute min unused nonce (#1402)
quasiyoke added a commit that referenced this issue Feb 10, 2025
@quasiyoke
Restore accounts with missing state (#1402)
99558b3
quasiyoke added a commit that referenced this issue Feb 10, 2025
@quasiyoke
Restore accounts with missing state (#1402)
d083bc6
@quasiyoke quasiyoke mentioned this issue Feb 10, 2025
Open
quasiyoke added a commit that referenced this issue Feb 10, 2025
@quasiyoke
Migrate EVM-managed accounts' state with broken nonce;
e41f812 
compute min unused nonce (#1402)
quasiyoke added a commit that referenced this issue Feb 10, 2025
@quasiyoke
Restore accounts with missing state (#1402)
8ea5ef5
quasiyoke added a commit that referenced this issue Feb 10, 2025
@quasiyoke
Restore accounts with missing state (#1402)
91da612
quasiyoke added a commit that referenced this issue Feb 10, 2025
@quasiyoke
Migrate EVM-managed accounts' state with broken nonce;
69f1928 
compute min unused nonce (#1402)
quasiyoke added a commit that referenced this issue Feb 10, 2025
@quasiyoke
Restore accounts with missing state (#1402)
dad2745
quasiyoke added a commit that referenced this issue Feb 11, 2025
@quasiyoke
Migrate EVM-managed accounts' state with broken nonce;
b9f6541 
compute min unused nonce (#1402)
quasiyoke added a commit that referenced this issue Feb 11, 2025
@quasiyoke
Restore accounts with missing state (#1402)
f7a1835
quasiyoke added a commit that referenced this issue Feb 11, 2025
@quasiyoke
Refactor fn contract_address to take nonce: u32
b400571 
(was `impl rlp::Encode`) (#1402)
quasiyoke added a commit that referenced this issue Feb 11, 2025
@quasiyoke
Take into account reading weight of precompiled contracts (#1402)
953a468
quasiyoke added a commit that referenced this issue Feb 11, 2025
@quasiyoke
Take into account reading weight of precompiled contracts (#1402)
1fccbba
quasiyoke added a commit that referenced this issue Feb 11, 2025
@quasiyoke
Check AccountInfo invariants after upgrade (#1402)
1132c80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tracking A tracking issue for a big multi-PR initiative
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmitrylavrenov