From 9eaefc77b0a7bc1db6dd9aa89c8fa3393cf34242 Mon Sep 17 00:00:00 2001
From: Karthick Ariyaratnam <karthyuom@gmail.com>
Date: Thu, 25 Apr 2024 16:02:22 -0400
Subject: [PATCH] Mention one of rediss:// and valkeys:// in error message, not
 both (#373)

When using a TLS scheme for valkey-cli and benchmark-cli compiled
without TLS, make the error message only mention the scheme used.

Before:

"valkeys:// and rediss:// are only supported when valkey-cli is compiled
with OpenSSL"

After, depending on which scheme the user tried to use:

"valkeys:// is only supported when valkey-cli is compiled with OpenSSL"
"rediss:// is only supported when valkey-cli is compiled with OpenSSL"

Follow up of #199.

---------

Signed-off-by: karthyuom <karthyuom@gmail.com>
Co-authored-by: k00809413 <karthick.ariyaratnam1@huawei.com>
---
 src/cli_common.c | 27 ++++++++++++---------------
 1 file changed, 12 insertions(+), 15 deletions(-)

diff --git a/src/cli_common.c b/src/cli_common.c
index 28f459272d..879e5a236d 100644
--- a/src/cli_common.c
+++ b/src/cli_common.c
@@ -328,26 +328,23 @@ void parseRedisUri(const char *uri, const char* tool_name, cliConnInfo *connInfo
     const char *userinfo, *username, *port, *host, *path;
 
     /* URI must start with a valid scheme. */
-    if (!strncasecmp(tlsscheme, curr, strlen(tlsscheme))) {
+    if (!strncasecmp(tlsscheme, curr, strlen(tlsscheme)) ||
+        !strncasecmp(redisTlsscheme, curr, strlen(redisTlsscheme))) {
 #ifdef USE_OPENSSL
         *tls_flag = 1;
-        curr += strlen(tlsscheme);
+        char *del = strstr(curr, "://");
+        curr += (del - curr) + 3;
 #else
-        fprintf(stderr,"valkeys:// and rediss:// are only supported when %s is compiled with OpenSSL\n", tool_name);
+        char *copy = strdup(curr);
+        char *curr_scheme = strtok(copy, "://");
+        fprintf(stderr,"%s:// is only supported when %s is compiled with OpenSSL\n", curr_scheme, tool_name);
+        free(copy);
         exit(1);
 #endif
-    } else if (!strncasecmp(redisTlsscheme, curr, strlen(redisTlsscheme))) {
-#ifdef USE_OPENSSL
-        *tls_flag = 1;
-        curr += strlen(redisTlsscheme);
-#else
-        fprintf(stderr,"valkeys:// and rediss:// are only supported when %s is compiled with OpenSSL\n", tool_name);
-        exit(1);
-#endif
-    } else if (!strncasecmp(scheme, curr, strlen(scheme))) {
-        curr += strlen(scheme);
-    } else if (!strncasecmp(redisScheme, curr, strlen(redisScheme))) {
-        curr += strlen(redisScheme);
+    } else if (!strncasecmp(scheme, curr, strlen(scheme)) ||
+               !strncasecmp(redisScheme, curr, strlen(redisScheme))) {
+        char *del = strstr(curr, "://");
+        curr += (del - curr) + 3;
     } else {
         fprintf(stderr,"Invalid URI scheme\n");
         exit(1);