From 68327248eb21d74fc78fa61e9ed00d4e0e09be10 Mon Sep 17 00:00:00 2001 From: Jason Guo <33064781+Xaroz@users.noreply.github.com> Date: Tue, 7 Jan 2025 15:10:23 -0600 Subject: [PATCH] fix: remove skip ci from workflow (#468) ### Description When both combine or optimize-svg have changes, whoever finishes last would not be able to push because the other one already commited changes. I removed [skip ci] because it is not necessary and the initial thought was that it would loop but that should not be the case. Once one of the workflow updates it will trigger another check and if the other workflow has changes it will check again and do the proper changes. ### Backward compatibility Yes ### Testing Manual --- .github/workflows/combine.yml | 2 +- .github/workflows/optimize-svg.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/combine.yml b/.github/workflows/combine.yml index 486aa20d3..5b3d6f2d1 100644 --- a/.github/workflows/combine.yml +++ b/.github/workflows/combine.yml @@ -58,7 +58,7 @@ jobs: CHANGES=$(git status -s) if [[ ! -z $CHANGES ]]; then git add . - git commit -m "Update chain metadata and address files [skip ci]" + git commit -m "Update chain metadata and address files" git push else echo "No changes to commit." diff --git a/.github/workflows/optimize-svg.yml b/.github/workflows/optimize-svg.yml index a11d57b1b..ac8738ce8 100644 --- a/.github/workflows/optimize-svg.yml +++ b/.github/workflows/optimize-svg.yml @@ -54,7 +54,7 @@ jobs: CHANGES=$(git status -s) if [[ ! -z $CHANGES ]]; then git add . - git commit -m "Optimize SVG files [skip ci]" + git commit -m "Optimize SVG files" git push else echo "No changes to commit."