github actions when running unit tests are not failing

[davidkel]

Some tests which fail when run in 18.x, 20.x, 22.x resulted in the following

which shows 18.x failed, but the other 2 reported as succeeded
A quick test shows that on 20.x npm run tests --workspaces results in a RC of 1 ($?) if a test fails and RC or 0 if all tests pass so why is github actions thinking it hasn't failed but not for all in the matrix ?

[Veer0x1]

@davidkel can you explain this issue in little more details? I tried to run this workflow on my fork, it passes for all the matrix

[davidkel]

@Veer0x1 There was a PR submitted which had failing unit tests. The failures were reported on all 3 unit test runs (ie node 18,20,22) however github only reported the failure on the node 18 run. It should not have shown ticks for the node 20 and node 22 runs. That's the issue.