Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use binary.BigEndian.PutUint64 for sim.Asset #283

Closed
manoranjith opened this issue Dec 8, 2021 · 0 comments · Fixed by #284
Closed

Use binary.BigEndian.PutUint64 for sim.Asset #283

manoranjith opened this issue Dec 8, 2021 · 0 comments · Fixed by #284

Comments

@manoranjith
Copy link

manoranjith commented Dec 8, 2021 •
edited
Loading

Location

[backend/sim/asset]

Problem

Currently, we use perunio.Encode method to encode the asset. This couples the sim.Asset to a specific serialization implementation.

Proposal

As suggested by @matthiasgeihs in the review of 272, use binary.BigEndian.PutUint64 directly for marshalling the sim.Asset which is of type int64.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use fixed length format for (un)marshalling asset boschresearch/go-perun
1 participant
@manoranjith