Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add version for each of the config files to hold helm chart version #202

Open
Anmol1696 opened this issue Aug 30, 2023 · 1 comment

Comments

@Anmol1696
Copy link
Collaborator

Overview

With the new cli starship we will have version as part of the config file read by the client.
But we can already add version to the config file with the install.sh file taking care of the rest.

Proposal

Add version pointing to the helm chart version deployed as part of the config.

# cat config.yaml
version: 0.1.46
...

This is then read in install.sh and --version is not passed as an arg.

Note: this is future compatible with the cli work too.

@Anmol1696 Anmol1696 mentioned this issue Sep 2, 2023
6 tasks
@Anmol1696
Copy link
Collaborator Author

Is this a good idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant