Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross origin fonts on multi-frame #812

Closed
fchasen opened this issue Oct 4, 2013 · 3 comments
Closed

Cross origin fonts on multi-frame #812

fchasen opened this issue Oct 4, 2013 · 3 comments
Assignees

Comments

@fchasen
Copy link

fchasen commented Oct 4, 2013

Icons in the toolbar, which was separated out in the multi-frame branch aren't showing up in Firefox. Firefox doesn't load the icomoon font, since it is hosted on a different server.

Would it be possible to configure the server (multi-frame-8.dokku.hypothes.is in this case) to add

Access-Control-Allow-Origin: *

to the header of the fonts that are requested in inject.css?

Original report at:
futurepress/epubjs-reader#2

@csillag
Copy link
Contributor

csillag commented Oct 4, 2013

+1

I am seeing this with PDF.js / FF, too. (#757, search for icomoon)

@tilgovi
Copy link
Contributor

tilgovi commented Oct 8, 2013

I'm surprised this is necessary. I didn't think CORS was needed for CSS references, since the data is not directly accessible by JS. I'll look into it.

@ghost ghost assigned tilgovi Oct 8, 2013
@tilgovi
Copy link
Contributor

tilgovi commented Oct 8, 2013

Okay. Yep. FF issue: https://bugzilla.mozilla.org/show_bug.cgi?id=604421
I'll do something about it.

@tilgovi tilgovi closed this as completed in 73a1f9d Oct 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants