From 7529e3b4ac8c91e05788820fd56263e3e71140c9 Mon Sep 17 00:00:00 2001 From: Caleb German Date: Mon, 12 Feb 2024 09:23:15 -0600 Subject: [PATCH] Updated imodel connection closed code and env.ts --- .../components/VersionCompareSelectModal.tsx | 2 +- packages/test-app-frontend/src/environment.ts | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/changed-elements-react/src/widgets/comparisonJobWidget/components/VersionCompareSelectModal.tsx b/packages/changed-elements-react/src/widgets/comparisonJobWidget/components/VersionCompareSelectModal.tsx index 49f55999..396c7e1d 100644 --- a/packages/changed-elements-react/src/widgets/comparisonJobWidget/components/VersionCompareSelectModal.tsx +++ b/packages/changed-elements-react/src/widgets/comparisonJobWidget/components/VersionCompareSelectModal.tsx @@ -251,7 +251,7 @@ const pollForComparisonJobTillComplete = async (args: RunStartComparisonV2Args) return; } comparisonJob = await getComparisonJob(); - if (comparisonJob.status === "Completed") { + if (comparisonJob.status === "Completed" && !isConnectionClosed) { conditionallyToastJobCompletion({ ...args, comparisonJob: { comparisonJob: comparisonJob } }); return; } diff --git a/packages/test-app-frontend/src/environment.ts b/packages/test-app-frontend/src/environment.ts index 3102fb29..1b1d3648 100644 --- a/packages/test-app-frontend/src/environment.ts +++ b/packages/test-app-frontend/src/environment.ts @@ -12,12 +12,11 @@ export function applyUrlPrefix(base: string, url = ""): string { /** * Prepends base with urlPrefix from env. - * dev- will default to qa-. - * no url prefix will default to qa. + * dev- will default to qa-{base} */ export function applyAuthUrlPrefix(base: string): string { let deploymentRegion = urlPrefix; - if ((!!urlPrefix) || urlPrefix === "dev") { + if (deploymentRegion === "dev-") { deploymentRegion = "qa-"; } const normalizedUrl = new URL(base);