Inconsistencies in Element API related to use of navigation properties

[khanaffan]

Inconsistencies in Element Api. Mainly there is bunch of places where we have navigation properties but we name or typed them inconsistently.

2. Elemen.model should have been a r RelatedModel type
3. GeometricElement.category should have been a RelatedCategory type.
4. Model .parentModel should have been RelatedModel type.
5. ViewDefintion.categorySelectionId should be RelatedCategory and it has Id postfix unlike model, category and parentModel
6. ViewDefintion.displayStyleId should be RelatedDisplayStyle and it has Id postfix unlike model, category and parentModel
7. ViewDefinition2d.baseModelId should be RelatedModel type and it has Id postfix unlike model, category and parentModel

Generally all navigation properties should be defined a such { id: Id64String, relClassName: string } using the RelatedElementProps interface

// Navigation properties
export class Element {
	public readonly model: Id64String;  // Navigation property
}
  
export abstract class GeometricElement {
	public category: Id64String;       // Navigation property	  
}

export class Model extends Entity {
	public readonly parentModel!: Id64String; // Navigation property
}
 
export abstract class ViewDefinition extends DefinitionElement {
	public categorySelectorId: Id64String;   // Navigation property
	public displayStyleId: Id64String;       // Navigation property
}
 
export class SpatialViewDefinition extends ViewDefinition3d {
	public modelSelectorId: Id64String;       // Navigation property
}

export class ViewDefinition2d extends ViewDefinition {
	public baseModelId: Id64String;           // Navigation property
}

// Json props
export interface ElementProps extends EntityProps {
	jsonProperties?: any;  // could be of same type as Element [key: string]: any;
}

[khanaffan]

@ColinKerr @aruniverse I logged the inconsistency that I found with element api.