:no_good: is replaced by 🙅‍♀️ instead of 🙅

[eramdam]

Like the title says 😅

This is reproducible on the demo

At first I assumed it was a regression I caused in my PR for emoji 15 but it seems to be caused by the no_good and woman-gesturing-no equivalence?

Perhaps the issue lies in https://github.com/iamcal/emoji-data itself? 😅

[eramdam]

According to https://projects.iamcal.com/emoji-data/table.htm, the equivalence shouldn't be there in the first place 😅

[iamcal]

This is working as intended.

In the original source data, :no_good: maps to U+1F645 ("FACE WITH NO GOOD GESTURE").

However, this codepoint has been obsoleted by 1F645-200D-2640-FE0F ("WOMAN GESTURING NO") when Apple (and then other vendors) added the gendered versions of these emoji.

This data (the obsoletes/obsoleted_by fields) is not shown in the HTML table, which adds to the confusion.

At present, this behavior is not optional. It would be pretty easy to make a preference to allow it to be ignored and the original codepoint chosen instead (the JS code in question starts with if (self.obsoletes_data[out.full_idx]){)

[eramdam]

But then is there a way to output 🙅? Or are consumers of the library expected to catch this case to work around it? 😅 (I see Slack properly translates :no_good: to 🙅 for example).

Or are you saying that making the obsolete-related behavior optional would allow to :no_good: -> 🙅 conversion to happen as "expected"?

[eramdam]

And I guess the issue happens in reverse in that using replace_unified with colons_mode = true with 🙅 produces :woman-gesturing-no: which feels like a bug?

[iamcal]

I'm saying that adding such a flag would keep the old behavior (from before gendered emoji replaced the neutral ones). Given that Apple has since back-tracked on the change and added back the gender neutral versions, this is probably a better default.

[iamcal]

PR #182 makes your desired behavior the default

Working on making it actually work :D

[eramdam]

I'm saying that adding such a flag would keep the old behavior (from before gendered emoji replaced the neutral ones). Given that Apple has since back-tracked on the change and added back the gender neutral versions, this is probably a better default.

Gotcha!

PR #182 makes your desired behavior the default

Thanks! 🙏 I can try testing this in our project next week, or maybe it's a safe change? I admit I'm not aware of other cases of obsolete(d) gendered emoji 🤔

[eramdam]

PR #182 makes your desired behavior the default

Working on making it actually work :D

Okay I thought i missed something when it didn't work in my (quick) testing :D