Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test dependencies and expand coverage #2

Open
iamgollum opened this issue Apr 20, 2020 · 0 comments
Open

Add test dependencies and expand coverage #2

iamgollum opened this issue Apr 20, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@iamgollum
Copy link
Contributor

iamgollum commented Apr 20, 2020

Obervation

Version 1.0 initial commit had no tests accompanied with it.

Add dependencies:

<dependency>
    <groupId>org.junit.jupiter</groupId>
    <artifactId>junit-jupiter-engine</artifactId>
    <version>5.6.2</version>
    <scope>test</scope>
</dependency>

<dependency>
     <groupId>org.mockito</groupId>
     <artifactId>mockito-core</artifactId>
     <version>3.3.3</version>
<scope>test</scope>

Action Item

Add tests at minimum for:

[x] DatabaseType#fromJdbcUrl
[ ] DatabaseFactory
[ ] JDBCWriter

@iamgollum iamgollum self-assigned this Apr 20, 2020
@iamgollum iamgollum added the enhancement New feature or request label Apr 20, 2020
@iamgollum iamgollum added the good first issue Good for newcomers label Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants