Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graceful-fs@2 and @3 support will be removed soon #143

Closed
ChALkeR opened this issue Jul 24, 2016 · 4 comments
Closed

graceful-fs@2 and @3 support will be removed soon #143

ChALkeR opened this issue Jul 24, 2016 · 4 comments

Comments

@ChALkeR
Copy link

ChALkeR commented Jul 24, 2016

Hi. ibm_db is currently #64 in my list of modules that would likely to be broken when nodejs/node#6413 lands (which is anticipated to happen before v7.0).

Note that graceful-fs@1 and graceful-fs@4 are ok and would not be broken by this, but a require() on graceful-fs@2 or graceful-fs@3 would cause an error soon.

That is, runtime warning fs: re-evaluating native module sources is not supported. would be turned into a throw.

If you or your deps use graceful-fs@2 or graceful-fs@3 in runtime — you are affected.

Tracking: nodejs/node#5213.

@bimalkjha
Copy link
Member

bimalkjha commented Jul 24, 2016

@ChALkeR ibm_db is not using graceful-fs@3 directly. It is the unzip package which is using graceful-fs@3.

/Users/bimaljha/nodework/installs> npm ls graceful-fs
/Users/bimaljha/nodework/installs
└─┬ [email protected]
├─┬ [email protected]
│ └── [email protected]
└─┬ [email protected]
└─┬ [email protected]
└── [email protected]

Seems, no one is maintaining this unzip package as it is 2 years old. ibm_db is using unzip.Parse() to unzip the .zip file on ntx64 platform only. Do you know any good alternative of unzip that ibm_db can use to unzip a .zip file on ntx64? Thanks.

@ChALkeR
Copy link
Author

ChALkeR commented Jul 24, 2016

@bimaljha I have not used them (or even checked them), but other popular alternatives are unzip2 (which is also affected, see glebdmitriew/node-unzip-2#13 and has last release two years ago) and yauzl (which seems to be fine).

I can't recommend them because I haven't used them, though.

@bimalkjha
Copy link
Member

bimalkjha commented Jul 30, 2016

@ChALkeR Thanks for the info. I'll try to use yauzl instead of unzip.

@rhtpandeyIN
Copy link
Contributor

Unzip has been removed from ibm_db module, replaced with node-unzipper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants