Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaup-up TodoEvaluator #690

Open
axunonb opened this issue Jan 11, 2025 · 1 comment
Open

Cleaup-up TodoEvaluator #690

axunonb opened this issue Jan 11, 2025 · 1 comment
Labels
enhancement

Comments

@axunonb
Copy link
Collaborator

axunonb commented Jan 11, 2025

  • Remove usage of DateUtil.GetSimpleDateTimeData (it returns IDateTime.Value which is better to understand)
  • Finally remove GetSimpleDateTimeData from DateUtil class
  • Refactor return Evaluate(Todo.Start, DateUtil.GetSimpleDateTimeData(beginningDate), DateUtil.GetSimpleDateTimeData(currDt).AddTicks(1), true); so that the magic AddTicks(1) becomes redundant.
@axunonb
Copy link
Collaborator Author

axunonb commented Jan 12, 2025

@minichma The evaluation seems to work different for Todo vs. CalendarEvent. Without AddTicks() the tests fail. Could you have a look at that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@axunonb