-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Submitted Data Table Error Cell Highlight Logic #2547
Comments
@demariadaniel Hi! The follow up table doesn't have any highlighted cells, but there are errors in the table: https://platform-ui.qa.argo.cancercollaboratory.org/submission/program/DATA-CA/clinical-data?tab=follow_up |
the issue still exists in https://platform-ui.qa.argo.cancercollaboratory.org/submission/program/DATA-CA/clinical-data?tab=follow_up, Dan will fix it as part of ticket #2535 . Moving back to in progress. |
@demariadaniel some cells are not highlighted: Issue will be fixed in #2620. |
Testing failed in staging, above issues are reproducible in QA, logged issue: #2653. Will move ticket forward. |
Lectern Client is updated to include specific values in the Donor error objects.
Update Submitted Data Table to only highlight cells which match donor ID, field name and error value
Errors are found @ ClinicalData Query -> ClinicalErrors -> error.info.value
See TODO at
components/pages/submission-system/program-submitted-data/ClinicalEntityDataTable/index.tsx
line 494This should reduce the number of cells highlighted; the table currently matches all cells w/ matching donor ID and field name
The text was updated successfully, but these errors were encountered: