Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Submitted Data Table Error Cell Highlight Logic #2547

Closed
demariadaniel opened this issue Jan 17, 2023 · 6 comments
Closed

Update Submitted Data Table Error Cell Highlight Logic #2547

demariadaniel opened this issue Jan 17, 2023 · 6 comments
Assignees
Labels

Comments

@demariadaniel
Copy link
Contributor

demariadaniel commented Jan 17, 2023

Lectern Client is updated to include specific values in the Donor error objects.

Update Submitted Data Table to only highlight cells which match donor ID, field name and error value
Errors are found @ ClinicalData Query -> ClinicalErrors -> error.info.value

See TODO at components/pages/submission-system/program-submitted-data/ClinicalEntityDataTable/index.tsx line 494

This should reduce the number of cells highlighted; the table currently matches all cells w/ matching donor ID and field name

@demariadaniel demariadaniel added the new-feature Request is a new feature label Jan 17, 2023
demariadaniel added a commit that referenced this issue Feb 8, 2023
* Updated Error Highlight Logic

* Separate Error Messages + Improved Record Counts

* Fix Record Counts
@Buwujiu
Copy link
Contributor

Buwujiu commented Feb 22, 2023

@demariadaniel Hi! The follow up table doesn't have any highlighted cells, but there are errors in the table: https://platform-ui.qa.argo.cancercollaboratory.org/submission/program/DATA-CA/clinical-data?tab=follow_up
Could you please take a look at it?

@Buwujiu
Copy link
Contributor

Buwujiu commented Mar 6, 2023

the issue still exists in https://platform-ui.qa.argo.cancercollaboratory.org/submission/program/DATA-CA/clinical-data?tab=follow_up, Dan will fix it as part of ticket #2535 . Moving back to in progress.

@Buwujiu
Copy link
Contributor

Buwujiu commented Apr 3, 2023

@lindaxiang
Copy link

lindaxiang commented May 5, 2023

Program: TEST-CA,

  1. table - Follow Up

Screenshot 2023-05-05 at 5 28 39 PM

  1. table - Immunotherapy

Screenshot 2023-05-05 at 5 41 02 PM

  1. table - Treatment
    There are more than one records for the same submitter_treatment_id, is this allowed and should these be highlighted?

Screenshot 2023-05-05 at 6 22 02 PM

@lindaxiang
Copy link

Program: ALEXIS-INTL
table: Primary Diagnosis

  • when lymph_nodes_examined_status field is 'No', they are NOT needed to be highlighted.

Screenshot 2023-05-05 at 6 26 20 PM

@Buwujiu
Copy link
Contributor

Buwujiu commented May 9, 2023

Testing failed in staging, above issues are reproducible in QA, logged issue: #2653. Will move ticket forward.

@Buwujiu Buwujiu closed this as completed May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants