Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go Major does not work with private repos #18

Open
KevinAnthony opened this issue Sep 21, 2022 · 3 comments
Open

Go Major does not work with private repos #18

KevinAnthony opened this issue Sep 21, 2022 · 3 comments
Labels
wontfix This will not be worked on

Comments

@KevinAnthony
Copy link

I'm looking at gomajor to evaluate when I need to update versions and for public repo's it's fine. However for private repo's it does not list them.
Is this something that is planned for the future.

My envvar GOPRIVATE is already set correctly.

@icholy
Copy link
Owner

icholy commented Sep 21, 2022

Currently, everything matching GOPRIVATE is skipped:

gomajor/main.go

Lines 88 to 90 in c65b0b7

if module.MatchPrefixPatterns(private, dep.Path) {
continue
}

Adding support for going directly to the VCS would require a significant amount of work that I can't commit to right now. But we can keep this issue open.

edit: in the meantime, I've added a note to the README about the limitation.

@icholy icholy added the wontfix This will not be worked on label Dec 7, 2022
@sanyatuning

This comment was marked as off-topic.

@icholy

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants