Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "jmx_scrape_error" check after provision/deploy #39

Open
1 task done
jnogol opened this issue Feb 27, 2019 · 0 comments
Open
1 task done

Add "jmx_scrape_error" check after provision/deploy #39

jnogol opened this issue Feb 27, 2019 · 0 comments
Assignees

Comments

@jnogol
Copy link
Collaborator

jnogol commented Feb 27, 2019

Prerequisites

Description

In the current role version, if the exporter scraping configuration provided is wrong, the role will execute everything and mark it as success, as the service doesn't fail but the scrape does. Adding a check after provision execution will help the role fail faster and mitigate this "silent misconfigurations".

Steps to Reproduce

  1. Add wrong exporter configuration
  2. Run the role in a playbook

Expected behavior: Fail, because configuration is wrong.

Actual behavior: Happily mark the execution as correct and let the exporter scrape wrongly.

Reproduces how often: Always

Versions

All

@jnogol jnogol self-assigned this Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant