Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data removal not working as expected #130

Open
wkerckho opened this issue Nov 7, 2022 · 2 comments
Open

Data removal not working as expected #130

wkerckho opened this issue Nov 7, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@wkerckho
Copy link
Contributor

wkerckho commented Nov 7, 2022

Data removal is implemented based on Clickhouse ALTER TABLE x DELETE queries, which can only delete records after shards have been merged. Because there are no timing guarantees with respect to merges in Clickhouse, Obelisk also cannot guarantee when data be deleted after performing a delete request. This is an issue and a different approach is required!

@wkerckho wkerckho self-assigned this Nov 7, 2022
@wkerckho
Copy link
Contributor Author

wkerckho commented Nov 7, 2022

The solution is to use the new DELETE FROM statement, which marks record as deleted immediately, automatically filtering out these records of all subsequent queries.

@MisterTimn MisterTimn added the enhancement New feature or request label Nov 8, 2022
@MisterTimn
Copy link
Contributor

Should note that this feature is still experimental in clickhouse 22.10, using the new statement for deletes will mark a minimum supported version for clickhouse and further custom config of CH (to allow the experimental lightweight delete).

Makes me think that we should look into a dependency version matrix and form a policy how we handle that with updates of said dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants