Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconstancies with the REST API's JSON #13

Open
jfischoff opened this issue Mar 6, 2014 · 0 comments
Open

Inconstancies with the REST API's JSON #13

jfischoff opened this issue Mar 6, 2014 · 0 comments

Comments

@jfischoff
Copy link

The wiki says for multi get https://github.com/imvu-open/istatd/wiki/Get-multiple-counters
says to use a JSON like

{
    "start": START,
    "end": END,
    "maxSamples": MAX,
    "keys": ["counter.name", "yet.another.counter.name"],
    "trailing": 0
}

But it should be stop instead of end

However, sometimes end is used instead of stop.

in the response documentation we have

{
    "start": int,
    "end":   int, 
    "counter.name": {
        "interval": int,
        "data": [
            {
                "time":  int,

what it really is:

{
    "start": int,
    "stop":   int, 
    "counter.name": {
        "interval": int,
        "data": [
            {
                "start": int,
                "end":   int, 
                "time":  int,

So we are not documenting that there is time interval in the bucket counter object and it uses end unlike the other intervals which use stop.

We should pick one convention and stick with it, and also update the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant