Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event remarks is NA #155

Open
peterdesmet opened this issue Feb 7, 2025 · 3 comments · May be fixed by #156
Open

Event remarks is NA #155

peterdesmet opened this issue Feb 7, 2025 · 3 comments · May be fixed by #156
Assignees

Comments

@peterdesmet
Copy link
Member

  1. Go to https://www.gbif.org/occurrence/4989590318 (a record in MUNTJAC_ANTWERP)
  2. Search for Event remarks
  3. The original value is NA

This is likely caused by write_dwc():

camtrapdp/R/write_dwc.R

Lines 148 to 152 in 56b34e6

dplyr::if_else(
as.logical(.data$baitUse),
"camera trap with bait",
"camera trap without bait"
),

Where baitUse is neither FALSE or TRUE, but NA, resulting in an "NA" text value being returned by paste0(). We should handle the case where baitUse is NA:

  • TRUE: "camera trap with bait",
  • FALSE: "camera trap without bait"
  • NA: "camera trap"
@peterdesmet
Copy link
Member Author

Note: this issue does not occur for any of the other fields. 👍

@sannegovaert
Copy link
Member

I prefer NA: ""
Otherwise we will have records with eventRemarks with only "camera trap" and that is redundant info.

@sannegovaert sannegovaert linked a pull request Feb 12, 2025 that will close this issue
@peterdesmet
Copy link
Member Author

Redundant with… samplingProtocol?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants