Page is not reloaded when using router.reload with preserveUrl: true option

[sjongejan]

Versions:

• @inertiajs/core version: 2.0.0
• @inertiajs/vue3 version: 2.0.0

Describe the problem:

When invoking router.reload with the option { preserveUrl: true }, the page does not reload as expected, even though network requests are performed successfully. This behaviour appears to conflict with the expected outcome when using preserveUrl.

Steps to reproduce:

import { router } from '@inertiajs/vue3';

router.reload({
  preserveUrl: true,
});

1. Implement the above code snippet in an Inertia.js project.
2. Trigger the router.reload method.
3. Observe that the page does not reload while network requests are being performed.

Suspected Cause:

The issue seems related to how the page is set in page.set within the core package. Specifically:

• A promise is created during the page.set process.
• This promise internally invokes either history.replaceState or history.pushState, depending on the circumstances.
• These methods evaluate the preserveUrl option and terminate early without proceeding further:
• • history.replaceState
• • history.pushState

The callback function (cb) associated with the promise does not appear to be invoked when preserveUrl is set to true. This might prevent the expected resolution of the reload logic.

Suggested Solution:

Verify and adjust the callback handling logic in the page.set process:

• Ensure that the callback cb is invoked even when preserveUrl is true.
• This would ensure consistent behaviour and allow the reload process to complete as expected.

[ravibpatel]

I am also experiencing this when using only with usePoll. It doesn't refresh the page.props even if the new values are received from the backend. Removing the preserverUrl fixes the issue but it should work with it.

[thetanaz]

Yep I was having tremendous issues with the new WhenVisible component and I finally figured out that this was the issue, preserveUrl stops the props from refreshing (or merging in my case)

[moymat]

Same issue here, preserveUrl: true seems to prevent the props from merging and the page hangs. Everything is fine when it's removed (except that the url changes, of course).

[CamKem]

#2135 will address this issue, hopefully the team is able to merge and release it soon.

[sjongejan]

#2163 is merged. I will close this issue.