Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages API model does not match documentation #45

Closed
l-dobrev-cch opened this issue Oct 25, 2024 · 1 comment
Closed

Messages API model does not match documentation #45

l-dobrev-cch opened this issue Oct 25, 2024 · 1 comment

Comments

@l-dobrev-cch
Copy link

Using Messages API to send messages with fail-over is not possible due to incomplete model classes.

Version: infobip-api-java-client:4.3.2

Some classes lack required attributes, which interferes with using Messages API corectly.

  • com.infobip.model.MessagesApiFailover

    • lacks content attribute
    • this disallows using failover with different channels.
    • the API documentation does not state that content is required for fail-over
    • this has been confirmed with customer support while resolving an issue
  • com.infobip.model.MessagesApiTemplateMessage

    • lacks failover attribute
    • this disallows using failover with initial WhatsApp messaging
  • com.infobip.model.MessagesApiTemplateMessage.destinations

    • the attribute is defined as list of ...MessagesApiToDestination
    • this disallows setting proper destinations for fail-over with ...MessagesApiTemplateMessage
    • suspected need to use ...MessagesApiMessageDestination instead

The expected behaviour is a successful delivery of a :

  • WhatsApp template message (template: authentication) to a user by their Phone Number
  • Viber fail-over with plain text message to the same user by their Phone Number
  • SMS fail-over with plain text message to the same user by their Phone Number

This issue is just about the inconsistent API model classes, and does not necessarily claim that the actual service will work as intended.

@l-dobrev-cch
Copy link
Author

The issue seems to have been resolved in #46 and the related version 4.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant