From 2f299e8ba5cbd16130ac1eb47ba9495201608230 Mon Sep 17 00:00:00 2001 From: Marcin <133694481+m7pr@users.noreply.github.com> Date: Fri, 31 Jan 2025 10:51:53 +0100 Subject: [PATCH] Remove lookup-refs (#365) Part of https://github.com/insightsengineering/coredev-tasks/issues/609 From now on, we will provide development dependencies in ``` Remotes: repo/project@branch ``` format, so it's explicitly visible in the DESCRIPTION file and can be handled by `pak::install`, `renv::install` and `remotes::install`. With development dependencies specified in CJ Pipelines configuration, this connection was hidden, and it was hard to install the package from the main branch (or any other branch) locally from user's machine. --- .github/workflows/check.yaml | 8 -------- .github/workflows/docs.yaml | 2 -- .github/workflows/release.yaml | 8 -------- .github/workflows/scheduled.yaml | 6 ------ 4 files changed, 24 deletions(-) diff --git a/.github/workflows/check.yaml b/.github/workflows/check.yaml index e957b6551..7a66630f2 100644 --- a/.github/workflows/check.yaml +++ b/.github/workflows/check.yaml @@ -42,8 +42,6 @@ jobs: unit-test-report-brand: >- https://raw.githubusercontent.com/insightsengineering/hex-stickers/main/thumbs/teal.png deps-installation-method: setup-r-dependencies - lookup-refs: | - insightsengineering/teal.code r-cmd-non-cran: name: R CMD Check (non-CRAN) 🧬 @@ -66,8 +64,6 @@ jobs: checking for unstated dependencies in vignettes .* NOTE checking top-level files .* NOTE deps-installation-method: setup-r-dependencies - lookup-refs: | - insightsengineering/teal.code coverage: name: Coverage πŸ“” @@ -78,8 +74,6 @@ jobs: additional-env-vars: | NOT_CRAN=true deps-installation-method: setup-r-dependencies - lookup-refs: | - insightsengineering/teal.code linter: if: github.event_name != 'push' name: SuperLinter πŸ¦Έβ€β™€οΈ @@ -92,8 +86,6 @@ jobs: with: auto-update: true deps-installation-method: setup-r-dependencies - lookup-refs: | - insightsengineering/teal.code gitleaks: name: gitleaks πŸ’§ uses: insightsengineering/r.pkg.template/.github/workflows/gitleaks.yaml@main diff --git a/.github/workflows/docs.yaml b/.github/workflows/docs.yaml index b26411183..8fdf0ae0f 100644 --- a/.github/workflows/docs.yaml +++ b/.github/workflows/docs.yaml @@ -43,5 +43,3 @@ jobs: default-landing-page: latest-tag additional-unit-test-report-directories: unit-test-report-non-cran deps-installation-method: setup-r-dependencies - lookup-refs: | - insightsengineering/teal.code diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index ce22f6fdf..56a0ccd59 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -17,8 +17,6 @@ jobs: with: default-landing-page: latest-tag deps-installation-method: setup-r-dependencies - lookup-refs: | - insightsengineering/teal.code validation: name: R Package Validation report πŸ“ƒ needs: release @@ -27,8 +25,6 @@ jobs: REPO_GITHUB_TOKEN: ${{ secrets.REPO_GITHUB_TOKEN }} with: deps-installation-method: setup-r-dependencies - lookup-refs: | - insightsengineering/teal.code release: name: Create release πŸŽ‰ uses: insightsengineering/r.pkg.template/.github/workflows/release.yaml@main @@ -54,8 +50,6 @@ jobs: unit-test-report-brand: >- https://raw.githubusercontent.com/insightsengineering/hex-stickers/main/thumbs/teal.png deps-installation-method: setup-r-dependencies - lookup-refs: | - insightsengineering/teal.code coverage: name: Coverage πŸ“” needs: [release, docs] @@ -66,8 +60,6 @@ jobs: additional-env-vars: | NOT_CRAN=true deps-installation-method: setup-r-dependencies - lookup-refs: | - insightsengineering/teal.code wasm: name: Build WASM packages πŸ§‘β€πŸ­ needs: release diff --git a/.github/workflows/scheduled.yaml b/.github/workflows/scheduled.yaml index af69858bd..325991155 100644 --- a/.github/workflows/scheduled.yaml +++ b/.github/workflows/scheduled.yaml @@ -56,9 +56,6 @@ jobs: ) name: revdepcheck ↩️ uses: insightsengineering/r.pkg.template/.github/workflows/revdepcheck.yaml@main - with: - lookup-refs: | - insightsengineering/teal.code rhub: if: > github.event_name == 'schedule' || ( @@ -67,6 +64,3 @@ jobs: ) name: R-hub 🌐 uses: insightsengineering/r.pkg.template/.github/workflows/rhub.yaml@main - with: - lookup-refs: | - insightsengineering/teal.code