Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix applying num_instructions_to_generate to simple pipelines #130

Closed
russellb opened this issue Jul 12, 2024 · 0 comments · Fixed by #144
Closed

Fix applying num_instructions_to_generate to simple pipelines #130

russellb opened this issue Jul 12, 2024 · 0 comments · Fixed by #144
Assignees
@russellb
Milestone
0.1.3

Comments

@russellb
Copy link
Member

In #86, I knowingly broke the simple pipelines in favor of restoring desired full pipeline behavior.

8179df5

That commit message explains what is needed to fix the simple ones to use the n parameter as desired. We need a way to specify in config that we want n set to this runtime parameter, since we do not want that for all cases n is not explicitly specified in config.
@russellb russellb mentioned this issue Jul 12, 2024
Merged
@markmc markmc added this to the 0.1.3 milestone Jul 15, 2024
@russellb russellb mentioned this issue Jul 15, 2024
Merged
russellb added a commit to russellb/sdg that referenced this issue Jul 16, 2024
@russellb
Set gen_kwargs['n'] dynamically in the simple pipelines
f7486f4 
We need a way to allow `--num-instructions`, or in the future
`--sdg-scale-factor`, to influence how many instructions we generate
using the simple pipelines. The way to do this seems to be to set `n`
to this value. Since this is a runtime parameter, and we only want to
set it for `n` in certain cases, add a new value for gen_kwargs['n']
called `scaled` which is a hint to use the runtime parameter here.

Closes instructlab#130

Signed-off-by: Russell Bryant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@russellb russellb

Labels
None yet
Projects
None yet
Milestone
0.1.3
Development

Successfully merging a pull request may close this issue.

Set gen_kwargs['n'] dynamically in the simple pipelines russellb/sdg
2 participants
@markmc @russellb