Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test job broken by #73 #147

Closed
russellb opened this issue Jul 16, 2024 · 0 comments · Fixed by #153
Closed

Unit test job broken by #73 #147

russellb opened this issue Jul 16, 2024 · 0 comments · Fixed by #153

Comments

@russellb
Copy link
Member

After merging #73

$ tox -e unit

================================================================================================== ERRORS ==================================================================================================
_________________________________________________________________________________ ERROR collecting tests/test_llmblock.py __________________________________________________________________________________
tests/test_llmblock.py:9: in <module>
    from src.instructlab.sdg.llmblock import LLMBlock
src/instructlab/sdg/__init__.py:29: in <module>
    from .importblock import ImportBlock
src/instructlab/sdg/importblock.py:6: in <module>
    from . import pipeline
src/instructlab/sdg/pipeline.py:102: in <module>
    "ImportBlock": importblock.ImportBlock,
E   AttributeError: partially initialized module 'src.instructlab.sdg.importblock' has no attribute 'ImportBlock' (most likely due to a circular import)
========================================================================================= short test summary info ==========================================================================================
ERROR tests/test_llmblock.py - AttributeError: partially initialized module 'src.instructlab.sdg.importblock' has no attribute 'ImportBlock' (most likely due to a circular import)
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
============================================================================================= 1 error in 1.72s =============================================================================================
unit: exit 2 (2.22 seconds) /Users/rbryant/src/instructlab/sdg> .tox/unit/bin/python -m pytest tests pid=11850
  unit: FAIL code 2 (4.04=setup[1.82]+cmd[2.22] seconds)
  evaluation failed :( (4.32 seconds)
russellb added a commit to russellb/sdg that referenced this issue Jul 16, 2024
This reverts commit 40b45ad.

Closes instructlab#147

Signed-off-by: Russell Bryant <[email protected]>
@markmc markmc closed this as completed in 919f6e9 Jul 16, 2024
jwm4 pushed a commit to jwm4/sdg that referenced this issue Dec 13, 2024
…_actions/actions/checkout-4.2.2

Bump actions/checkout from 4.2.1 to 4.2.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant