Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extraction of timestamps should be from volume_frames #916

Open
samupicard opened this issue Jan 21, 2025 · 0 comments
Open

extraction of timestamps should be from volume_frames #916

samupicard opened this issue Jan 21, 2025 · 0 comments
Assignees

Comments

@samupicard
Copy link
Member

for single depth mpci data, neural_frames and volume_frames are equivalent. But for multi-depth data, they are not (e.g. for 2 planes, there are twice as many edges in neural_frames than in volume_frames).

Because the time extractor works on neural_frames only, we have issues with multi-plane data, e.g. the mpci.times dataset ends up being twice as long as the mpci.ROIActivityDeconvolved, mpci.ROIActivityF and mpci.ROINeuropilActivity datasets.

I believe a simple fix would be to change this line to read out volume_frames instead of neural_frames here, but there may be other places where this needs work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants