New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transpose resets the song key so only one line gets transposed #3

Open

ryanmitchell opened this issue Sep 17, 2024 · 0 comments · May be fixed by #4

ryanmitchell commented Sep 17, 2024

When doing a complete transpose, you are resetting the song key here:
https://github.com/intelektron/chordpro-php/blob/f198a8a1820ffc6ee85c94f373f2c1048d583f41/src/Transposer.php#L126C29-L126C51

Which means only the first line is transposed.

ryanmitchell linked a pull request

that will close this issue

Fix complete transposition #4

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment