oaipmh: update admin list view #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrcastro2
force-pushed
the
add-pre-tag-to-spec
branch
from
d6f41bf to
baec637
Compare
kpsherva
changed the base branch from
feature/administration-oai2
to
master
jrcastro2
force-pushed
the
add-pre-tag-to-spec
branch
from
baec637 to
2543c8d
Compare
* display spec with <pre> tag * displays value with Formatter cmp * closes inveniosoftware/invenio-administration#94 * closes inveniosoftware/invenio-administration#105
jrcastro2
force-pushed
the
add-pre-tag-to-spec
branch
from
2543c8d to
b112c92
Compare
kpsherva
reviewed
Sep 22, 2022
| @@ -14,7 +14,7 @@ import { NotificationController } from "@js/invenio_administration/src/ui_messag | |||
| const domContainer = document.getElementById("invenio-search-config"); | |||
|
|
|||
| const sortColumns = (columns) => | |||
| Object.entries(columns).sort((a, b) => a[1].order > b[1].order); | |||
| Object.entries(columns).sort((a, b) => a[1].order - b[1].order); | |||
There was a problem hiding this comment.
why was this changed to -? I think sort function expects a boolean to be returned as a result of comparator func
There was a problem hiding this comment.
Because otherwise it doesn't work, we had the same issue in invenio-adminsitration, we updated it there but forgot to change it here.
This is how it was looking before:
There was a problem hiding this comment.
cross-checked with https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort, good to go
kpsherva
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<pre>tag invenio-administration#94