Skip to content
This repository has been archived by the owner on Mar 30, 2021. It is now read-only.

Android Manifest Documentation discrepancies #94

Open
jeffsteinmetz opened this issue Feb 1, 2019 · 0 comments
Open

Android Manifest Documentation discrepancies #94

jeffsteinmetz opened this issue Feb 1, 2019 · 0 comments

Comments

@jeffsteinmetz
Copy link

jeffsteinmetz commented Feb 1, 2019

In the sample application, is there any documentation as to why android.permission.SYSTEM_ALERT_WINDOW is required as a permission?

https://github.com/invertase/react-native-firebase-starter/blob/master/android/app/src/main/AndroidManifest.xml#L7

It is not listed in the docs
https://rnfirebase.io/docs/v5.x.x/notifications/android

In the docs, it recommends adding the following

<uses-permission android:name="android.permission.INTERNET" />
<uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED" />
 <uses-permission android:name="android.permission.VIBRATE" />

It also appears RECEIVE_BOOT_COMPLETED and VIBRATE are not shown in the sample application.
Is there an example for RECEIVE_BOOT_COMPLETED and VIBRATE used (per the docs vs sample app?)

Also the docs suggest this in android/app/src/main/AndroidManifest.xml

<activity
  ...
  android:launchMode="singleTop"
>

Is there any location in the docs or sample app that clarify the different Android manifest configs?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant