Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where should the websocket server live? #5

Open
DevinBayly opened this issue Aug 19, 2019 · 1 comment
Open

Where should the websocket server live? #5

DevinBayly opened this issue Aug 19, 2019 · 1 comment

Comments

@DevinBayly
Copy link
Contributor

I'm playing with Atom's editor now as I can't find much about changes tracking in vscode, but all of a sudden I'm wondering whether it makes sense to have a websocket server included in each plugin. It would continue to greatly simplify setup, but also it means that there's redundancy where there doesn't have to be? More thoughts are appreciated here.

@DevinBayly
Copy link
Contributor Author

For simplicity's sake I'm including the nodejs ws websocket server in the atom and vs code editors. It doesn't complicate the logic of the extensions that much and I could probably externalize it if there's a reason to later on without much effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant