Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

一个小建议:统一markers与heatmap内坐标props名称 #1

Open
fufjvnvnf opened this issue Jun 15, 2017 · 3 comments
Open

一个小建议:统一markers与heatmap内坐标props名称 #1

fufjvnvnf opened this issue Jun 15, 2017 · 3 comments

Comments

@fufjvnvnf
Copy link

非常喜欢这个插件!这里只是一个很小的改动建议,但是会方便许多。目前markers接受的json格式是“longitude”和“latitude”,而heatmap是“lng”和“lat”,这导致我在想在同一页面上同时显示markers和heatmap时必须把相同的坐标变成两个json传进去。如果统一了名称就只需要一份了,方便很多。希望能够考虑改动!

@fufjvnvnf
Copy link
Author

还漏了一个小地方。在markers里每个坐标pair是被一个position包起来的,而heatmap只是无脑的堆上去,没有加这一层。如果这里也能统一样式就更好了。

@ioslh
Copy link
Owner

ioslh commented Jun 15, 2017

有道理。markers 我准备也拆出来,尽量兼容一下,大概这个周末

@fufjvnvnf
Copy link
Author

fufjvnvnf commented Jun 16, 2017

谢谢!如果真的要拆出来markers的话最好给他加上visible这一选项!现在貌似还没有支持,也就是我把visible={false}传给markers之后markers还是能照常显示。如果这个包括进去也会方便许多!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants