Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add timeouts #89

Open
2 tasks
laurentsenta opened this issue Jun 26, 2023 · 0 comments
Open
2 tasks

feat: add timeouts #89

laurentsenta opened this issue Jun 26, 2023 · 0 comments

Comments

@laurentsenta
Copy link
Contributor

We added a default timeout per test of 2 minutes to catch tests that would hang the CI
#37 (comment)

We're probably going to need "expected timeouts" for requests:
#85 (comment)

Creating this issue to capture discussions/notes.

Mains questions:

  • I guess the behavior of a local Kubo daemon running in offline mode, and a fully deployed decentralized gateway will be very different, do we want to define timeouts at the test level ("that request should take less than 500ms") or at the gateway level ("that gateway should reply in less than 500ms")?
  • Is it going to be driven by the specs?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant