Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend value keys with protocol codec once it is defined #25

Open
ischasny opened this issue Feb 6, 2023 · 2 comments
Open

Prepend value keys with protocol codec once it is defined #25

ischasny opened this issue Feb 6, 2023 · 2 comments

Comments

@ischasny
Copy link
Contributor

ischasny commented Feb 6, 2023

The DHT specification for double hashing requires value keys to start with a codec. Add codec to the DHStore once it materialises. Things to consider:

  • The codec will exist only for encryption function rotation purpose;
  • We don't necessarily have to store it with each record - appending in realtime would work too.
@masih
Copy link
Member

masih commented Feb 6, 2023

We probably should add the coded in go-indexer-core and validate here?

@ischasny
Copy link
Contributor Author

ischasny commented Feb 6, 2023

Not sure yet where would be the best place to have it... The codec itself would be defined in go-multicodec, but where do we exactly add it is up for debate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants