From 0b1e3812da9c20f13bd7be1f7aa8cb8f2bbb5004 Mon Sep 17 00:00:00 2001
From: Dani Garcia <dgarcia@irontec.com>
Date: Tue, 6 Feb 2024 16:39:44 +0100
Subject: [PATCH] core: handle administrators activation

---
 app/config/packages/security.yaml             |  4 +++
 app/config/routes.yaml                        |  9 ++++++
 .../App/Controller/Administrator/Activate.php | 28 +++++++++++++++++
 .../Administrator/ActivateAdministrator.php   | 30 +++++++++++++++++++
 ...dministratorLifecycleServiceCollection.php |  2 +-
 .../Administrator/SendActivationEmail.php     | 17 ++++-------
 6 files changed, 77 insertions(+), 13 deletions(-)
 create mode 100644 app/src/App/Controller/Administrator/Activate.php
 create mode 100644 app/src/Demo/Application/Service/Administrator/ActivateAdministrator.php

diff --git a/app/config/packages/security.yaml b/app/config/packages/security.yaml
index d545fc7..a08ebbe 100755
--- a/app/config/packages/security.yaml
+++ b/app/config/packages/security.yaml
@@ -43,6 +43,10 @@ security:
             pattern:  ^/token/refresh
             stateless: true
 
+        activate_admin:
+            pattern: ^/activate_admin/\d+$
+            security: false
+
         api:
             pattern:   ^/.+
             stateless: true
diff --git a/app/config/routes.yaml b/app/config/routes.yaml
index 063a943..3a84f30 100755
--- a/app/config/routes.yaml
+++ b/app/config/routes.yaml
@@ -11,8 +11,17 @@ api_admin_login:
 post_send_administrator_activation_email:
     path: '/administrators/{id}/send_activation_email'
     methods: ['POST']
+    requirements:
+        id: '\d+'
     defaults:
         _controller: App\Controller\Administrator\SendActivationEmail
         _api_item_operation_name: 'send_activacion_email'
         _api_receive: false
 
+get_activate_administrator:
+    path: '/activate_admin/{id}'
+    methods: ['GET']
+    requirements:
+        id: '\d+'
+    defaults:
+        _controller: App\Controller\Administrator\Activate
diff --git a/app/src/App/Controller/Administrator/Activate.php b/app/src/App/Controller/Administrator/Activate.php
new file mode 100644
index 0000000..deb145a
--- /dev/null
+++ b/app/src/App/Controller/Administrator/Activate.php
@@ -0,0 +1,28 @@
+<?php
+
+namespace App\Controller\Administrator;
+
+use Demo\Application\Service\Administrator\ActivateAdministrator;
+use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpFoundation\Request;
+
+class Activate
+{
+    public function __construct(
+        private ActivateAdministrator $activateAdministrator
+    ) {
+    }
+
+    public function __invoke(Request $request): Response
+    {
+        $administratorId = (int) $request->get('id');
+
+        try {
+            $this->activateAdministrator->execute($administratorId);
+        } catch(\DomainException $e) {
+            return new Response($e->getMessage(), $e->getCode());
+        }
+
+        return new Response('Administrator activated', 200);
+    }
+}
diff --git a/app/src/Demo/Application/Service/Administrator/ActivateAdministrator.php b/app/src/Demo/Application/Service/Administrator/ActivateAdministrator.php
new file mode 100644
index 0000000..1f0e706
--- /dev/null
+++ b/app/src/Demo/Application/Service/Administrator/ActivateAdministrator.php
@@ -0,0 +1,30 @@
+<?php
+
+namespace Demo\Application\Service\Administrator;
+
+use Demo\Domain\Model\Administrator\AdministratorDto;
+use Demo\Domain\Model\Administrator\AdministratorRepository;
+use Ivoz\Core\Domain\Service\EntityTools;
+
+class ActivateAdministrator
+{
+    public function __construct(
+        private AdministratorRepository $administratorRepository,
+        private EntityTools $entityTools
+    ) {
+    }
+
+    public function execute(int $administratorId): void
+    {
+        $administrator = $this->administratorRepository->find($administratorId);
+
+        if ($administrator === null) {
+            throw new \DomainException('Administrator not found.', 404);
+        }
+
+        /** @var AdministratorDto $administratorDto */
+        $administratorDto = $this->entityTools->entityToDto($administrator);
+        $administratorDto->setActive(1);
+        $this->entityTools->persistDto($administratorDto, $administrator);
+    }
+}
diff --git a/app/src/Demo/Domain/Service/Administrator/AdministratorLifecycleServiceCollection.php b/app/src/Demo/Domain/Service/Administrator/AdministratorLifecycleServiceCollection.php
index c583cde..69cbcd8 100644
--- a/app/src/Demo/Domain/Service/Administrator/AdministratorLifecycleServiceCollection.php
+++ b/app/src/Demo/Domain/Service/Administrator/AdministratorLifecycleServiceCollection.php
@@ -15,7 +15,7 @@ class AdministratorLifecycleServiceCollection implements LifecycleServiceCollect
 
     /** @var array<array-key, array> $bindedBaseServices */
     public static $bindedBaseServices = [
-        "post_persist" =>
+        "on_commit" =>
         [
             \Demo\Domain\Service\Administrator\SendActivationEmail::class => 200,
         ],
diff --git a/app/src/Demo/Domain/Service/Administrator/SendActivationEmail.php b/app/src/Demo/Domain/Service/Administrator/SendActivationEmail.php
index 82a8d62..dd795a5 100644
--- a/app/src/Demo/Domain/Service/Administrator/SendActivationEmail.php
+++ b/app/src/Demo/Domain/Service/Administrator/SendActivationEmail.php
@@ -7,11 +7,11 @@
 
 class SendActivationEmail implements AdministratorLifecycleEventHandlerInterface
 {
-    public const POST_PERSIST_PRIORITY = self::PRIORITY_NORMAL;
+    public const ON_COMMIT_PRIORITY = self::PRIORITY_NORMAL;
 
     public function __construct(
-        private SendActivationEmailInterface $activationEmail,
-        private LoggerInterface $logger
+        private SendActivationEmailInterface $sendActivationEmail,
+        private LoggerInterface              $logger
     ) {
     }
 
@@ -21,7 +21,7 @@ public function __construct(
     public static function getSubscribedEvents(): array
     {
         return [
-            self::EVENT_POST_PERSIST => self::POST_PERSIST_PRIORITY
+            self::EVENT_ON_COMMIT => self::ON_COMMIT_PRIORITY
         ];
     }
 
@@ -40,13 +40,6 @@ public function execute(AdministratorInterface $administrator): void
             return;
         }
 
-        $id = $administrator->getId();
-        if ($id === null) {
-            throw new \DomainException('Administrator not found');
-        }
-
-        $this->activationEmail->execute($administrator);
-
-        $this->logger->info("Administrator created with Id {$id}");
+        $this->sendActivationEmail->execute($administrator);
     }
 }